Renamed exported targets and files

[vrcomputing]

Relates to #359

• QSkinny Internal CMake Target Names: lowercase

# src/CMakeLists.txt
set(target qskinny)

if(BUILD_QSKDLL)
    qsk_add_library(${target} SHARED ${SOURCES} ${HEADERS} ${PRIVATE_HEADERS})
else()
    qsk_add_library(${target} STATIC ${SOURCES} ${HEADERS} ${PRIVATE_HEADERS})
endif()

# qmlexport/CMakeLists.txt
set(target qskqmlexport)
qsk_add_library(${target} SHARED ${SOURCES} ${HEADERS})

• QSkinny Exported CMake Target Names: UpperCase

Example CMake Filenames

QSkinnyConfig.cmake
QSkinnyConfigVersion.cmake
QSkinnyQmlExportTargets-debug.cmake
QSkinnyQmlExportTargets.cmake
QSkinnyTargets-debug.cmake
QSkinnyTargets.cmake
QSkinnyTools.cmake

• QSkinny Exported CMake Namespace: QSkinny

# <CMAKE_INSTALL_PREFIX>/lib/cmake/QSkinny/QSkinnyTargets.cmake
...
add_library(QSkinny::QSkinny SHARED IMPORTED)
...

# <CMAKE_INSTALL_PREFIX>/lib/cmake/QSkinny/QSkinnyQmlExportTargets.cmake
...
add_library(QSkinny::QSkinnyQmlExport SHARED IMPORTED)
...

TODOs

• fix/unify/clarify weird qskqmlexport.lib and qskqmlexport.dll installation

This state creates the following structure in the installation folder:

QSkinny Install Binary Directory

• <CMAKE_INSTALL_PREFIX>/bin
• <CMAKE_INSTALL_PREFIX>/bin/qskqmlexport.dll ❓ why not next to qskqmlexport.lib
• <CMAKE_INSTALL_PREFIX>/bin/svg2qvg.exe

QSkinny Install Include Directories

• <CMAKE_INSTALL_PREFIX>/include
• <CMAKE_INSTALL_PREFIX>/include/qskinny
• <CMAKE_INSTALL_PREFIX>/include/qskinny/QskAbstractButton.h
• <CMAKE_INSTALL_PREFIX>/include/qskinny/QskQml.h
• ...

QSkinny Install Library Directories

• <CMAKE_INSTALL_PREFIX>/lib
• <CMAKE_INSTALL_PREFIX>/lib/qskqmlexport.lib ❓ why not next to qskqmlexport.dll

QSkinny Install CMake Directories

• <CMAKE_INSTALL_PREFIX>/lib/cmake
• <CMAKE_INSTALL_PREFIX>/lib/cmake/QSkinny
• <CMAKE_INSTALL_PREFIX>/lib/cmake/QSkinny/QSkinnyConfig.cmake
• <CMAKE_INSTALL_PREFIX>/lib/cmake/QSkinny/QSkinnyConfigVersion.cmake
• <CMAKE_INSTALL_PREFIX>/lib/cmake/QSkinny/QSkinnyQmlExportTargets-debug.cmake
• <CMAKE_INSTALL_PREFIX>/lib/cmake/QSkinny/QSkinnyQmlExportTargets.cmake
• <CMAKE_INSTALL_PREFIX>/lib/cmake/QSkinny/QSkinnyTargets-debug.cmake
• <CMAKE_INSTALL_PREFIX>/lib/cmake/QSkinny/QSkinnyTargets.cmake
• <CMAKE_INSTALL_PREFIX>/lib/cmake/QSkinny/QSkinnyTools.cmake

QSkinny Install Core Library Directory

• <CMAKE_INSTALL_PREFIX>/lib/qskinny
• <CMAKE_INSTALL_PREFIX>/lib/qskinny/qskinny.dll
• <CMAKE_INSTALL_PREFIX>/lib/qskinny/qskinny.lib

QSkinny Install Plugin Directories

• <CMAKE_INSTALL_PREFIX>/lib/qskinny/plugins
• <CMAKE_INSTALL_PREFIX>/lib/qskinny/plugins/platforminputcontexts
• <CMAKE_INSTALL_PREFIX>/lib/qskinny/plugins/platforminputcontexts/qskinputcontext.dll
• <CMAKE_INSTALL_PREFIX>/lib/qskinny/plugins/platforminputcontexts/qskinputcontext.lib

QSkinny Install Skin Directories

• <CMAKE_INSTALL_PREFIX>/lib/qskinny/plugins/skins
• <CMAKE_INSTALL_PREFIX>/lib/qskinny/plugins/skins/fluent2skin.dll
• <CMAKE_INSTALL_PREFIX>/lib/qskinny/plugins/skins/fluent2skin.lib
• <CMAKE_INSTALL_PREFIX>/lib/qskinny/plugins/skins/material3skin.dll
• <CMAKE_INSTALL_PREFIX>/lib/qskinny/plugins/skins/material3skin.lib
• <CMAKE_INSTALL_PREFIX>/lib/qskinny/plugins/skins/squiekskin.dll
• <CMAKE_INSTALL_PREFIX>/lib/qskinny/plugins/skins/squiekskin.lib

[vrcomputing]

include all possible CMake scripts and mark them as optional if e.g. controlled by a CMake option

[vrcomputing]

Subjectively I don't think we need an additional sub directory in the CMAKE_CURRENT_BINARY_DIR since it is already QSkinny's own build folder. It's not wrong, just not necessary...

Using CMAKE_CURRENT_BINARY_DIR makes us support the "QSkinny as a sub folder" scenario

[vrcomputing]

@uwerat Besides the following weird placement this PR is ready for review/merging:

<CMAKE_INSTALL_PREFIX>/bin/qskqmlexport.dll ❓ why not next to qskqmlexport.lib
<CMAKE_INSTALL_PREFIX>/lib/qskqmlexport.lib ❓ why not next to qskqmlexport.dll

Is there a reason why <CMAKE_INSTALL_PREFIX>\lib\qskinny\qskinny.dll and <CMAKE_INSTALL_PREFIX>\lib\qskqmlexport.lib are in different directories?

Suggestion: All libraries in <CMAKE_INSTALL_PREFIX>\lib

• <CMAKE_INSTALL_PREFIX>\lib\qskinny.dll
• <CMAKE_INSTALL_PREFIX>\lib\qskinny.lib ( .lib for 🪟 s )
• <CMAKE_INSTALL_PREFIX>\lib\qskqmlexport.dll
• <CMAKE_INSTALL_PREFIX>\lib\qskqmlexport.lib ( .lib for 🪟 s )

[vrcomputing]

PS: @uwerat is there a reason not to include .pdb in the package?

e.g. next to .lib / .dll files <CMAKE_INSTALL_PREFIX>\lib\qskinny.pdb
e.g. next to .lib / .dll files <CMAKE_INSTALL_PREFIX>\lib\qskqmlexport.pdb

[vrcomputing]

PPS: we can also just put the

If we remove set(PACKAGE_NAME QSkinnyQmlExport) from qskinny\qmlexport\CMakeLists.txt change set_target_properties(${target} PROPERTIES EXPORT_NAME QSkinnyQmlExport) we can put all exported targets into the collective QSkinnyTargets.cmake e.g. <CMAKE_INSTALL_PREFIX>\lib\cmake\QSkinny\QSkinnyTargets-debug.cmake

# generated
...
# Import target "QSkinny::QSkinny" for configuration "Debug"
set_property(TARGET QSkinny::QSkinny APPEND PROPERTY IMPORTED_CONFIGURATIONS DEBUG)
set_target_properties(QSkinny::QSkinny PROPERTIES
  IMPORTED_IMPLIB_DEBUG "${_IMPORT_PREFIX}/lib/qskinny/qskinny.lib"
  IMPORTED_LOCATION_DEBUG "${_IMPORT_PREFIX}/lib/qskinny/qskinny.dll"
  )

list(APPEND _cmake_import_check_targets QSkinny::QSkinny )
list(APPEND _cmake_import_check_files_for_QSkinny::QSkinny "${_IMPORT_PREFIX}/lib/qskinny/qskinny.lib" "${_IMPORT_PREFIX}/lib/qskinny/qskinny.dll" )

# Import target "QSkinny::QSkinnyQmlExport" for configuration "Debug"
set_property(TARGET QSkinny::QSkinnyQmlExport APPEND PROPERTY IMPORTED_CONFIGURATIONS DEBUG)
set_target_properties(QSkinny::QSkinnyQmlExport PROPERTIES
  IMPORTED_IMPLIB_DEBUG "${_IMPORT_PREFIX}/lib/qskqmlexport.lib"
  IMPORTED_LINK_DEPENDENT_LIBRARIES_DEBUG "QSkinny::QSkinny"
  IMPORTED_LOCATION_DEBUG "${_IMPORT_PREFIX}/bin/qskqmlexport.dll"
  )

list(APPEND _cmake_import_check_targets QSkinny::QSkinnyQmlExport )
list(APPEND _cmake_import_check_files_for_QSkinny::QSkinnyQmlExport "${_IMPORT_PREFIX}/lib/qskqmlexport.lib" "${_IMPORT_PREFIX}/bin/qskqmlexport.dll" )
...