Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify QSkinny Cmake Package #363

Merged
merged 6 commits into from
Jan 13, 2024
Merged

Unify QSkinny Cmake Package #363

merged 6 commits into from
Jan 13, 2024

Conversation

vrcomputing
Copy link
Contributor

@vrcomputing vrcomputing commented Jan 11, 2024 •
edited
Loading

  • fix qml export installation location
  • fix build break for non msvc compilers regarding pdbs

@vrcomputing vrcomputing marked this pull request as draft January 11, 2024 16:50
@vrcomputing
Copy link
Contributor Author

Renaming QSkinnyTargets.cmake to prevent confusion between framework and the QSkinny target deferred

@vrcomputing vrcomputing changed the title Changed QSkinny Cmake Package Unify QSkinny Cmake Package Jan 11, 2024
@vrcomputing vrcomputing marked this pull request as ready for review January 11, 2024 18:15
@lgtmak
Copy link
Contributor

lgtmak commented Jan 12, 2024

Please update the docs and examples for the namespace changes.

@uwerat uwerat merged commit 7e2e361 into uwerat:master Jan 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vrcomputing @lgtmak @uwerat