Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text input: Implement completely for Material 3 (and Fluent 2) #437

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

peter-ha
Copy link
Collaborator

Screenshot from 2024-10-15 13-17-32

Screenshot from 2024-10-15 13-18-12

Screenshot from 2024-10-15 13-17-23

Screenshot from 2024-10-15 13-18-04

Screenshot from 2024-10-15 13-58-07

Screenshot from 2024-10-15 13-58-10

@peter-ha peter-ha force-pushed the bugfix/400-text-input branch 2 times, most recently from e0f6c18 to b43455a Compare October 15, 2024 13:10
@hestrro
Copy link

hestrro commented Oct 26, 2024

Can these functions be used now? I downloaded the latest library, but I cannot set the above effects. For example, outlined in the upper left corner

@hestrro
Copy link

hestrro commented Oct 26, 2024

Is the circular button in the upper right corner using QskPushButton, or is it another control? Because when I use qskpushbutton to draw such a small round button icon will be offset

@peter-ha
Copy link
Collaborator Author

Can these functions be used now? I downloaded the latest library, but I cannot set the above effects. For example, outlined in the upper left corner

This pull request here has not been merged yet; for now you can check out this branch (edelhirsch:bugfix/400-text-input) and once it has been merged you can switch to master

@peter-ha
Copy link
Collaborator Author

Is the circular button in the upper right corner using QskPushButton, or is it another control? Because when I use qskpushbutton to draw such a small round button icon will be offset

No, it is not a control of its own, it is just a subcontrol of QskTextInput named TrailingIcon.

@hestrro
Copy link

hestrro commented Oct 28, 2024

Is the custom zoom close button in the upper right corner of your window using QskPushButton?

@peter-ha
Copy link
Collaborator Author

Is the custom zoom close button in the upper right corner of your window using QskPushButton?

image

Do you mean the "hamburger" menu button? Yes, that is a normal QskPushButton, see for reference https://github.com/uwerat/qskinny/blob/master/examples/gallery/main.cpp#L233

@peter-ha peter-ha force-pushed the bugfix/400-text-input branch from b43455a to 386c679 Compare November 11, 2024 09:26
@peter-ha
Copy link
Collaborator Author

Resolved some merge conflicts with the slider stuff and added text selection styling for M3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants