Remove usage of __kernel_name_generator as not required for non-compiled Kernel's
#1935
Conversation
SergeyKopienko
requested review from
rarutyun
and removed request for
rarutyun
… usage of __kernel_name_generator as not required Signed-off-by: Sergey Kopienko <[email protected]>
SergeyKopienko
force-pushed
the
dev/skopienko/fix_kernel_name_generator_usage
branch
from
acc4f20 to
c1da480
Compare
SergeyKopienko
changed the title
__kernel_name_generator as not required__kernel_name_generator as not required for non-compiled Kernel's
Signed-off-by: Sergey Kopienko <[email protected]>
| template <typename _ExecutionPolicy, typename _BrickTag, typename __FoundStateType, typename _Predicate, | ||
| typename... _Ranges> | ||
| __FoundStateType | ||
| operator()(_ExecutionPolicy&& __exec, _BrickTag __brick_tag, const std::size_t __rng_n, |
There was a problem hiding this comment.
I see that we are removing the device backend tag here and below as a side effect of this change. I understand that it is not technically necessary as device backend is the only option at this point.
However, we decided to include it originally. Is it useful as a form of documentation still (this is my only guess as to why it was originally included)?
There was a problem hiding this comment.
This seems like a reasonable change. I agree that the __kernel_name_generator should not be necessary here because we have no need to pre-compile the kernel and interrogate characteristics of the compiled kernel, and therefore shouldn't be used.
I'm OK with removing the device_backend_tag argument as well, but I want to draw attention to it and make sure we consider that, as it isn't in the original goal of the PR.
It would be good to get another approval here, but I think it looks good.
In this PR we remove usage of
__kernel_name_generatorfrom__parallel_find_oras not required.We should avoid to use
__kernel_name_generatorfor not-compiler Kernels (when absent the call of__kernel_compilerin the code) due a lot of char codes in template names.For example we may see these names with char codes from VTune.
Attention :
Otherwise you will see a lot of unsignificant changes due the formatting has been changed.
Thanks.