Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kernel compilation logic more portable #1991

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

dmitriy-sobolev
Copy link
Contributor

@dmitriy-sobolev dmitriy-sobolev commented Jan 6, 2025

Disable kernel compilation if it is not supported. For instance, ACPP does not support kernel bundles, nor sycl::program, which appears to be a former DPC++ feature or an artifact from previous SYCL revisions.

@dmitriy-sobolev dmitriy-sobolev force-pushed the dev/dmitriy-sobolev/kernel-compile branch from 9b38c5c to 9c70d88 Compare January 7, 2025 11:29
@dmitriy-sobolev dmitriy-sobolev marked this pull request as ready for review January 8, 2025 11:22
Copy link
Contributor

@MikeDvorskiy MikeDvorskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitriy-sobolev dmitriy-sobolev merged commit e4e4b8f into main Jan 22, 2025
22 of 23 checks passed
@dmitriy-sobolev dmitriy-sobolev deleted the dev/dmitriy-sobolev/kernel-compile branch January 22, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants