Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Added numa_support rfc #1535

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

vossmjp
Copy link
Contributor

@vossmjp vossmjp commented Oct 23, 2024

Description

Adds RFC for simplified NUMA support

Fixes # - issue number(s) if exists

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

@vossmjp vossmjp changed the title Added numa_support rfc [RFC] Added numa_support rfc Oct 30, 2024
Copy link
Contributor

@aleksei-fedotov aleksei-fedotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos to fix.

rfcs/proposed/simplified_numa_support/README.md Outdated Show resolved Hide resolved
rfcs/proposed/simplified_numa_support/README.md Outdated Show resolved Hide resolved
rfcs/proposed/simplified_numa_support/README.md Outdated Show resolved Hide resolved
rfcs/proposed/simplified_numa_support/README.md Outdated Show resolved Hide resolved
rfcs/proposed/simplified_numa_support/README.md Outdated Show resolved Hide resolved
@vossmjp vossmjp marked this pull request as ready for review January 9, 2025 19:27
@vossmjp vossmjp added the RFC label Jan 9, 2025
akukanov
akukanov previously approved these changes Jan 13, 2025
Copy link
Contributor

@akukanov akukanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for its purpose.

Below is the example based on existing oneTBB documentation that demonstrates the use
of these APIs to pin threads to different arenas to each of the NUMA nodes available
on a system, submit work across those `task_arena` objects and into associated
`task_group`` objects, and then wait for work again using both the `task_arena`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`task_group`` objects, and then wait for work again using both the `task_arena`
`task_group` objects, and then wait for work again using both the `task_arena`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants