Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with non-english locale #1606

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moritz-h
Copy link

Description

The build fails on non-english systems due to parsing localized gcc output in CMake.
This was partially already fixed in #1450, but next to the LANG env variable also LC_ALL needs to be explicitly set to C otherwise LC_ALL or LANGUAGE can take precedence over LANG.
See gettext docs and GCC docs.

Type of change

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant