Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legacy *.lib files not obeying CMAKE_INSTALL_LIBDIR variable. #1613

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yalcinerbora
Copy link

Description

This simple fix replaces hard-coded "lib" literals on legacy .lib file installations. Similarly, it also changes the destination of .dbg file (when debug information is separated from the .so).

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes (debatable but yes?, somewhere someone probably explicitly fixed this and their code will break maybe)
  • No
  • Unknown

Notify the following users

Other information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant