Code

Package review PR#1

Code

Open

KarthikSubbarao wants to merge 73 commits intotestvalkey-io/valkey-bloom:testfrom unstablevalkey-io/valkey-bloom:unstableCopy head branch name to clipboard

+5,880-1

Commits

Commits on Sep 10, 2024

• Initial commit

  Show description for 5237a10
  KarthikSubbarao

  committed
  5237a10

  Copy full SHA for 5237a10

• Add support for BF.ADD, BF.EXISTS, BF.CARD

  Show description for a96c08a
  KarthikSubbarao

  committed
  a96c08a

  Copy full SHA for a96c08a

• Update README

  Show description for be97a25
  KarthikSubbarao

  committed
  be97a25

  Copy full SHA for be97a25

• Optimize bloom operations to use a reference to already created Bloom objects. Update RDB load/save

  Show description for 5ebc1cb
  KarthikSubbarao

  committed
  5ebc1cb

  Copy full SHA for 5ebc1cb

• Remove older Bloom APIs using prev serialization apporach

  Show description for 8557b55
  KarthikSubbarao

  committed
  8557b55

  Copy full SHA for 8557b55

• Add Dev Profile in Cargo.toml for debugging

  Show description for 1729520
  KarthikSubbarao

  committed
  1729520

  Copy full SHA for 1729520

• Create Module Datatype and support RDB load, save, free

  Show description for be80d9d
  KarthikSubbarao

  committed
  be80d9d

  Copy full SHA for be80d9d

• Update README.md

  Show description for ed4d0f9
  KarthikSubbarao

  committed
  ed4d0f9

  Copy full SHA for ed4d0f9

• Add support for BF.RESERVE and expansion config

  Show description for 2db0e4b
  KarthikSubbarao

  committed
  2db0e4b

  Copy full SHA for 2db0e4b

• Add support for BF.INFO

  Show description for 778c219
  KarthikSubbarao

  committed
  778c219

  Copy full SHA for 778c219

• Add support for BF.MEXISTS

  Show description for b11970e
  KarthikSubbarao

  committed
  b11970e

  Copy full SHA for b11970e

• Add support for BF.MADD

  Show description for bdf5f0d
  KarthikSubbarao

  committed
  bdf5f0d

  Copy full SHA for bdf5f0d

• Update error handling / messages and update expansion logic

  Show description for 8f5e3fc
  KarthikSubbarao

  committed
  8f5e3fc

  Copy full SHA for 8f5e3fc

• Add auto scaling support for bloom filters

  Show description for 5545680
  KarthikSubbarao

  committed
  5545680

  Copy full SHA for 5545680

• Fix RDB Save for scaled filters

  Show description for 42d015c
  KarthikSubbarao

  committed
  42d015c

  Copy full SHA for 42d015c

• Refactoring

  Show description for 481ecac
  KarthikSubbarao

  committed
  481ecac

  Copy full SHA for 481ecac

• Update TODOs

  Show description for ff60817
  KarthikSubbarao

  committed
  ff60817

  Copy full SHA for ff60817

• Fix mem_usage calculation

  Show description for 1c1b6ab
  KarthikSubbarao

  committed
  1c1b6ab

  Copy full SHA for 1c1b6ab

• Update Cargo.toml

  Show description for d00fa99
  KarthikSubbarao

  committed
  d00fa99

  Copy full SHA for d00fa99

• minor refactoring

  Show description for 053d5e9
  KarthikSubbarao

  committed
  053d5e9

  Copy full SHA for 053d5e9

• Add support for BF.INSERT and fix multi add logic

  Show description for fbdfb5b
  KarthikSubbarao

  committed
  fbdfb5b

  Copy full SHA for fbdfb5b

• Update error messages

  Show description for a2343b7
  KarthikSubbarao

  committed
  a2343b7

  Copy full SHA for a2343b7

• Type conversions + struct updates to use less memory

  Show description for 753575a
  KarthikSubbarao

  committed
  753575a

  Copy full SHA for 753575a

• fixed few clippy warnings

  Show description for 3f85cae
  KarthikSubbarao

  committed
  3f85cae

  Copy full SHA for 3f85cae

• fix clippy warnings

  Show description for 159c938
  KarthikSubbarao

  committed
  159c938

  Copy full SHA for 159c938

• Update README and address all clippy warnings

  Show description for bebf72a
  KarthikSubbarao

  committed
  bebf72a

  Copy full SHA for bebf72a

• Specify package license

  Show description for ef4e215
  KarthikSubbarao

  committed
  ef4e215

  Copy full SHA for ef4e215

• Cargo fmt

  Show description for 6ca68c5
  KarthikSubbarao

  committed
  6ca68c5

  Copy full SHA for 6ca68c5

• Add support for COPY commands on BloomFilter datatypes

  Show description for b7504e9
  KarthikSubbarao

  committed
  b7504e9

  Copy full SHA for b7504e9

• Add more documentation

  Show description for 3ebb15b
  KarthikSubbarao

  committed
  3ebb15b

  Copy full SHA for 3ebb15b

• Migrate to valkeymodule-rs

  Show description for ec72262
  KarthikSubbarao

  committed
  ec72262

  Copy full SHA for ec72262

• Implement free_effort datatype callback, Make aux_load cb ignore invocations, update documentation

  Show description for 2816474
  KarthikSubbarao

  committed
  2816474

  Copy full SHA for 2816474

• Defrag Bloom Object callback

  Show description for 3c285d5
  KarthikSubbarao

  committed
  3c285d5

  Copy full SHA for 3c285d5

• Minor Refactoring + Handle Non Scaling Filters which are filled to capacity

  Show description for ffb722f
  KarthikSubbarao

  committed
  ffb722f

  Copy full SHA for ffb722f

• Replication support + Update Module/Datatype name + Refactor

  Show description for 5b0df15
  KarthikSubbarao

  committed
  5b0df15

  Copy full SHA for 5b0df15

• Update data type name and use static str for errors

  Show description for c66243d
  KarthikSubbarao

  committed
  c66243d

  Copy full SHA for c66243d

• Support keyspace notifications for write operations

  Show description for 0d2ad8a
  KarthikSubbarao

  committed
  0d2ad8a

  Copy full SHA for 0d2ad8a

• Add Python testing framework to support Integration testing of the bloom module + Add basic sanity tests

  Show description for 85e20fd
  KarthikSubbarao

  committed
  85e20fd

  Copy full SHA for 85e20fd

Commits on Sep 14, 2024

• Types, Ranges, limit updates and overflow handling

  Show description for 0b9a90d
  KarthikSubbarao

  committed
  0b9a90d

  Copy full SHA for 0b9a90d

Commits on Sep 17, 2024

• Add unit testing support using the valkeymodule-rs enable-system-alloc feature

  Show description for a180f42
  KarthikSubbarao

  committed
  a180f42

  Copy full SHA for a180f42

• Add unit testing for scaling & non scaling filters for behavior and false positive rate correctness

  Show description for 736a48a
  KarthikSubbarao

  committed
  736a48a

  Copy full SHA for 736a48a

Commits on Sep 18, 2024

• Merge pull request #3 from KarthikSubbarao/unstable

  Show description for 6d0a4b6
  KarthikSubbarao

  authored
  6d0a4b6

  Copy full SHA for 6d0a4b6

Commits on Sep 19, 2024

• Adding github workflow for building, running format checks, unit tests, integration tests and ASAN testing

  Show description for dee8a7e
  zackcam

  committed
  dee8a7e

  Copy full SHA for dee8a7e

• Merge pull request #5 from zackcam/unstable

  Show description for 145f9b2
  KarthikSubbarao

  authored
  145f9b2

  Copy full SHA for 145f9b2

• RDB format optimization: Using a fixed seed for bloom filters (#2)

  Show description for 282599d
  

  YueTang-Vanessa

  authored and

  KarthikSubbarao

  committed
  282599d

  Copy full SHA for 282599d

• Update build.sh and fix import in save/restore pytest

  Show description for 687bec7
  KarthikSubbarao

  committed
  687bec7

  Copy full SHA for 687bec7

Commits on Oct 2, 2024

• Adding replication ability to valkey test case, changing waiter functionality for more flexibility in the future (#6)

  Show description for f299216
  zackcam

  authored
  f299216

  Copy full SHA for f299216

Commits on Oct 9, 2024

• Integration tests for commands, delete operations, expiry, compatibility (#7)

  Show description for 4d38649
  

  YueTang-Vanessa

  authored and

  KarthikSubbarao

  committed
  4d38649

  Copy full SHA for 4d38649

Commits on Oct 10, 2024

• Updating _ to -in lib.rs. Also updating loading from rdb to use a trait instead (#14)

  Show description for fde4d37
  zackcam

  authored
  fde4d37

  Copy full SHA for fde4d37

Commits on Oct 15, 2024

• Add Integration Testing for correctness of scaling and non scaling filters and other core functionality validation (#15)

  Show description for f5aa39e
  KarthikSubbarao

  authored
  f5aa39e

  Copy full SHA for f5aa39e

Commits on Oct 17, 2024

• Add integration tests for maxmemory scenarios and replication correctness. Fixed others tests and updated the build.sh script for running single integration tests (#16)

  Show description for 57a7901
  KarthikSubbarao

  committed
  57a7901

  Copy full SHA for 57a7901

Commits on Oct 29, 2024

• Handle bloom object max allowed size limit, switch fp rate to f64 (#18)

  Show description for 12031b2
  KarthikSubbarao

  committed
  12031b2

  Copy full SHA for 12031b2

Commits on Nov 5, 2024

• Adding info handler, that contains three fields, num_objects, num_filters and memory_bytes. Additionally updated drop and created tests around this new info handler (#19)

  Show description for 31d21c0
  zackcam

  authored
  31d21c0

  Copy full SHA for 31d21c0

Commits on Nov 21, 2024

• add bf.load to support bloom filter aofrewrite. (#17)

  Show description for b301baa
  

  wuranxx

  authored and

  KarthikSubbarao

  committed
  b301baa

  Copy full SHA for b301baa

• Add new metrics to show capacity and items across objects (#20)

  Show description for a33e0e3
  

  YueTang-Vanessa

  authored and

  KarthikSubbarao

  committed
  a33e0e3

  Copy full SHA for a33e0e3

Commits on Nov 30, 2024

• Support for DEBUG DIGEST module data type callback (#21)

  Show description for 7c25468
  

  nnmehta

  authored and

  KarthikSubbarao

  committed
  7c25468

  Copy full SHA for 7c25468

Commits on Dec 4, 2024

• Updating how we create BloomFilter from rdb loads and upgrading bloomfilter dependency to version 3.0 (#23)

  Show description for 34d6fb0
  

  zackcam

  and

  KarthikSubbarao

  authored
  34d6fb0

  Copy full SHA for 34d6fb0

Commits on Dec 5, 2024

• Support random seed per bloom object by default (configurable) (#27)

  Show description for 1b0d819
  KarthikSubbarao

  committed
  1b0d819

  Copy full SHA for 1b0d819

Commits on Dec 6, 2024

• Add tightening_ratio support in BloomFilterType structure (#26)

  Show description for f10a4e5
  nnmehta

  authored
  f10a4e5

  Copy full SHA for f10a4e5

• Adding a wrong type error message when performing a bloom operation on a non bloom key (#30)

  Show description for eaa218f
  zackcam

  authored
  eaa218f

  Copy full SHA for eaa218f

Commits on Dec 10, 2024

• Updating defragmentation to defrag both bloomfiltertype and bloomfiler structs (#24)

  Show description for d8a0508
  zackcam

  authored
  d8a0508

  Copy full SHA for d8a0508

• Adding bloom acl category to commands. Added tests to check that the commands contain the correct acl categories (#29)

  Show description for a5ec8de
  zackcam

  authored
  a5ec8de

  Copy full SHA for a5ec8de

Commits on Dec 11, 2024

• Update default configuration and related test (#28)

  Show description for 4a8af80
  YueTang-Vanessa

  authored
  4a8af80

  Copy full SHA for 4a8af80

Commits on Dec 12, 2024

• Deterministic replication - bloom object creation should have the same properties on replica nodes to match the object on the primary (#32)

  Show description for 8b94c17
  KarthikSubbarao

  committed
  8b94c17

  Copy full SHA for 8b94c17

Commits on Dec 13, 2024

• Adding bloom defrag hits and misses to info, added check these metrics get incremented in defrag test (#33)

  Show description for 3589d30
  zackcam

  authored
  3589d30

  Copy full SHA for 3589d30

Commits on Dec 17, 2024

• Deflaking tests to remove chance of false positives causing tests to fail (#34)

  Show description for 98ccdc6
  

  zackcam

  and

  KarthikSubbarao

  authored
  98ccdc6

  Copy full SHA for 98ccdc6

Commits on Dec 19, 2024

• Add TIGHTENING Ratio and FP_Rate configs support (#31)

  Show description for 9baf6fc
  nnmehta

  authored
  9baf6fc

  Copy full SHA for 9baf6fc

• Fix size check and update build script to fail on warnings

  Show description for 6a514bf
  KarthikSubbarao

  committed
  6a514bf

  Copy full SHA for 6a514bf

Commits on Jan 3, 2025

• Add test for loading rdb onto non-bloom cluster (#36)

  Show description for 1c949fb
  YueTang-Vanessa

  authored
  1c949fb

  Copy full SHA for 1c949fb

Commits on Jan 11, 2025

• Large bloom object handling + Rename to BloomFilterType to BloomObject (#37)

  Show description for ab158bb
  KarthikSubbarao

  committed
  ab158bb

  Copy full SHA for ab158bb

Commits on Jan 12, 2025

• ACL Updates, BF.INSERT updates, other misc updates (#38)

  Show description for a9b578e
  KarthikSubbarao

  committed
  a9b578e

  Copy full SHA for a9b578e

• Update README.md (#39)

  Show description for 1bb7d25
  KarthikSubbarao

  authored
  1bb7d25

  Copy full SHA for 1bb7d25

Commits on Jan 17, 2025

• Adding a bloom command keyspace test (#40)

  Show description for 591ab10
  zackcam

  authored
  591ab10

  Copy full SHA for 591ab10