Adding optional arg to BF.INSERT to allow users to check if their bloom filter can reach the desired size #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT
Need to go over error messages
Need to change how we calculate capacity
Changes
Adding ATLEASTCAPCITY as an optional arg of BF.INSERT. New bf.insert command will look like:
BF.INSERT <key> [CAPACITY capacity] [ERROR fp_error] [EXPANSION expansion] [NOCREATE] [NONSCALING] [ATLEASTCAPACITY wantedcapacity] [ITEMS item]
This argument will help a user know whether the command will fail - at the time of creation if they want to expand their filter to a certain size.
There are two new error messages associated with this:
Added checks for these two error messages in
test_bloom_command.py