-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make documentation link more obvious #98
Conversation
Thanks for your contribution! The change looks fine, but could you please sign-off the commit you pushed? |
hi |
Yup, you got it right :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
=======================================
Coverage 75.17% 75.18%
=======================================
Files 132 132
Lines 34480 34480
=======================================
+ Hits 25922 25923 +1
+ Misses 8558 8557 -1 ☔ View full report in Codecov by Sentry. |
fair enough |
Now you forgot to sign the commit while fixing its contents :) Please sign it again just like the first time. |
that was too much problem for two lines of doc |
Signed-off-by: amirreza <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much and sorry for all the back and forth!
Pull Request check-list
Description of change
added a link