Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make documentation link more obvious #98

Merged
merged 1 commit into from
Sep 23, 2024
Merged

make documentation link more obvious #98

merged 1 commit into from
Sep 23, 2024

Conversation

amirreza8002
Copy link
Contributor

@amirreza8002 amirreza8002 commented Sep 23, 2024

Pull Request check-list

  • [ x] Do tests and lints pass with this change?
  • [ x] Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • [ x] Is the new or changed code fully tested?
  • [ x] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • [ x] Is there an example added to the examples folder (if applicable)?

Description of change

added a link

@mkmkme
Copy link
Collaborator

mkmkme commented Sep 23, 2024

Thanks for your contribution! The change looks fine, but could you please sign-off the commit you pushed?
https://github.com/valkey-io/valkey-py/pull/98/checks?check_run_id=30516332278

@amirreza8002
Copy link
Contributor Author

hi
this is something i hadn't done before,
did the push fix it?

@mkmkme
Copy link
Collaborator

mkmkme commented Sep 23, 2024

Yup, you got it right :)

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.18%. Comparing base (dcc1713) to head (acc3f77).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   75.17%   75.18%           
=======================================
  Files         132      132           
  Lines       34480    34480           
=======================================
+ Hits        25922    25923    +1     
+ Misses       8558     8557    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
@amirreza8002
Copy link
Contributor Author

fair enough
i should work on my English literature :p

@mkmkme
Copy link
Collaborator

mkmkme commented Sep 23, 2024

Now you forgot to sign the commit while fixing its contents :) Please sign it again just like the first time.

@amirreza8002
Copy link
Contributor Author

that was too much problem for two lines of doc
i apologize

@aiven-sal aiven-sal enabled auto-merge September 23, 2024 15:45
Copy link
Member

@aiven-sal aiven-sal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much and sorry for all the back and forth!

@aiven-sal aiven-sal merged commit b060e38 into valkey-io:main Sep 23, 2024
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants