-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add latency stats around cluster config file operations #1534
Add latency stats around cluster config file operations #1534
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1534 +/- ##
============================================
+ Coverage 70.92% 70.95% +0.03%
============================================
Files 120 120
Lines 65004 65055 +51
============================================
+ Hits 46104 46162 +58
+ Misses 18900 18893 -7
|
When the cluster changes, we need to persist the cluster configuration, and these file IO operations may cause latency. Signed-off-by: Binbin <[email protected]>
33047ce
to
523f1e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also add some sanity tests?
i can get this ouput in my local mac, but it is not certain that they will show in CI. Do you have a better idea?
|
Didn't follow. Could you explain why it won't show up in CI? |
If it is 0ms, it will not show up in the tests. |
5e6bda7
to
671a100
Compare
Signed-off-by: Binbin <[email protected]>
671a100
to
8efc449
Compare
When the cluster changes, we need to persist the cluster configuration, and these file IO operations may cause latency. Signed-off-by: Binbin <[email protected]> Signed-off-by: proost <[email protected]>
When the cluster changes, we need to persist the cluster configuration,
and these file IO operations may cause latency.