Test coverage for ECHO for reply schema validation #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viktor Söderqvist <[email protected]>
zuiderkwast
added
test-failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1549 +/- ##
============================================
- Coverage 71.00% 70.93% -0.07%
============================================
Files 120 120
Lines 65061 65061
============================================
- Hits 46194 46154 -40
- Misses 18867 18907 +40 |
Signed-off-by: Viktor Söderqvist <[email protected]>
enjoy-binbin
approved these changes
Jan 13, 2025
zuiderkwast
commented
Jan 13, 2025
| @@ -1220,7 +1220,7 @@ jobs: | |||
| if: | | |||
| (github.event_name == 'workflow_dispatch' || | |||
| (github.event_name == 'schedule' && github.repository == 'valkey-io/valkey') || | |||
| (github.event_name == 'pull_request' && github.event.pull_request.base.ref != 'unstable')) && | |||
| (github.event_name == 'pull_request' && (contains(github.event.pull_request.labels.*.name, 'run-extra-tests') || github.event.pull_request.base.ref != 'unstable'))) && | |||
There was a problem hiding this comment.
@enjoy-binbin I was going to revert this change before merging. Sorry i didn't mention it.
I guess it's fine to run schema validator in run-extra-tests, but it takes one hour to run.
proost
pushed a commit
to proost/valkey
that referenced
this pull request
Jan 17, 2025
After valkey-io#1545 disabled some tests for reply schema validation, we now have another issue that ECHO is not covered. ``` WARNING! The following commands were not hit at all: echo ERROR! at least one command was not hit by the tests ``` This patch adds a test case for ECHO in the unit/other test suite. I haven't checked if there are more commands that aren't covered. Signed-off-by: Viktor Söderqvist <[email protected]> Signed-off-by: proost <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1545 disabled some tests for reply schema validation, we now have another issue that ECHO is not covered.
(https://github.com/valkey-io/valkey/actions/runs/12728730819/job/35479652660)
This patch adds a test case for ECHO in the unit/other test suite. I haven't checked if there are more commands that aren't covered.