Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add maxSupportedVersion for Troopo tokens #587

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

finnian0826
Copy link
Contributor

@finnian0826 finnian0826 commented Nov 14, 2024

use same maxSupportedVersion as Aave token (conversation here)

Setting it for tokens added in this PR, and the following PRs from Jean:

Copy link
Contributor

@satish-ravi satish-ravi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tagging @jeanregisser to confirm on this

Comment on lines 71 to 73
"maxSupportedVersion": {
"valora": "1.95.1"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep that one, it's not a pool token, but a stable coin.

@finnian0826 finnian0826 enabled auto-merge (squash) November 20, 2024 17:05
@finnian0826 finnian0826 merged commit 2f6df01 into main Nov 20, 2024
4 checks passed
@finnian0826 finnian0826 deleted the finnian0826/hide-troopo-tokens branch November 20, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants