Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SQLiteConnection.swift to support readonly mode for file-bas… #74

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vi4m
Copy link

@vi4m vi4m commented Oct 9, 2024

Readonly option for sqlite

@vi4m vi4m requested a review from gwynne as a code owner October 9, 2024 21:38
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can get away with this. @gwynne any thoughts?

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 66.20%. Comparing base (7353cca) to head (f467879).

Files with missing lines Patch % Lines
Sources/SQLiteNIO/SQLiteConnection.swift 61.53% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   66.28%   66.20%   -0.08%     
==========================================
  Files           9        9              
  Lines         777      787      +10     
==========================================
+ Hits          515      521       +6     
- Misses        262      266       +4     
Files with missing lines Coverage Δ
Sources/SQLiteNIO/SQLiteConnection.swift 68.33% <61.53%> (-0.76%) ⬇️

@gwynne
Copy link
Member

gwynne commented Jan 2, 2025

Could use a test

@gwynne
Copy link
Member

gwynne commented Jan 2, 2025

Also the API breakage checker has a halfway-valid complaint, for once 🤨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants