Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove url.parse / 删除已弃用的对 url.parse 的调用 #148

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

mhornbacher
Copy link
Contributor

@mhornbacher mhornbacher commented Mar 6, 2024

这个问题处理了NodeJS中的下列弃用警告,通过使用URL类而不是全局解析方法来处理。两者都有pathname属性,这是这里所需的。(This handles the following deprecation in NodeJS by using the URL class rather than the global parse method which both have the pathname attribute which is what is required here.)

[DEP0169] DeprecationWarning: url.parse() behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for url.parse() vulnerabilities.

修复 #149 (Fixes #149)

This handles the following deprecation in NodeJS by using the URL class rather than the global `parse` method which both have the `pathname` attribute which is what is required here.

[DEP0169] DeprecationWarning: url.parse() behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for url.parse() vulnerabilities.
@mhornbacher mhornbacher changed the title Remove url.parse Remove url.parse / 删除已弃用的对 url.parse 的调用 Mar 6, 2024
Copy link

@avi-kiddom avi-kiddom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow thanks for fixing this! I could not figure out what was causing it!

@mhornbacher mhornbacher requested a review from avi-kiddom March 13, 2024 14:43
@mhornbacher mhornbacher marked this pull request as draft March 27, 2024 20:16
@mhornbacher mhornbacher marked this pull request as ready for review March 27, 2024 20:16
@mhornbacher
Copy link
Contributor Author

@avi-kiddom I think your approval hid the PR from the contributors :(

@jinmao88 jinmao88 merged commit 4a32df2 into vbenjs:main Apr 5, 2024
1 check passed
@mhornbacher mhornbacher deleted the patch-1 branch April 10, 2024 01:24
@mhornbacher
Copy link
Contributor Author

Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

不推荐调用 url.parse / Call to URL.parse is deprecated
3 participants