Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liquidation updates #900

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Liquidation updates #900

merged 3 commits into from
Jan 31, 2024

Conversation

candida-d
Copy link
Member

Closes #812

@candida-d candida-d requested a review from edd as a code owner January 30, 2024 16:46
@candida-d candida-d linked an issue Jan 30, 2024 that may be closed by this pull request
Changes to liquidation & margin relationships #812
Closed
@candida-d candida-d requested a review from witgaw January 30, 2024 16:49
@edd edd removed their request for review January 30, 2024 16:54
witgaw
witgaw reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@witgaw witgaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some minor comments.

docs/tutorials/proposals/new-market-proposal.md Outdated Show resolved Hide resolved
docs/tutorials/proposals/new-market-proposal.md Outdated Show resolved Hide resolved
docs/concepts/trading-on-vega/market-protections.md Outdated Show resolved Hide resolved
@candida-d candida-d requested a review from witgaw January 30, 2024 21:11
witgaw
witgaw approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@witgaw witgaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@candida-d candida-d merged commit f148e47 into main Jan 31, 2024
1 check passed
@candida-d candida-d deleted the 812-changes-to-liquidation branch January 31, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@witgaw witgaw witgaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changes to liquidation & margin relationships
2 participants
@candida-d @witgaw