Feature 22921 mig colorize field in tree views jpr #4

dz0 · 2024-03-12T13:01:01Z

https://hive.versada.eu/projects/siramis/work_packages/22921/

codecov · 2024-03-12T13:03:19Z

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Implementation now is based on updating `style` attribute of `cell/td` instead of directly manipulating element's CSS value. Cleanup docs about no more implemented `colors` parameter for `tree`

maciej-wichowski

FYI, when pushing not migrated module to 17.0-versada, you should set "installable": False in __manifest__.py. Branch 17.0-versada is for our internal use, so if someone would add it into his project, Odoo would reject modules on init due to module version mismatch.

maciej-wichowski · 2024-03-12T14:27:06Z

web_tree_dynamic_colored_field/static/description/index.html

@@ -529,13 +507,15 @@ <h1>Contributors</h1>
 <li>Guewen Baconnier &lt;<a class="reference external" href="mailto:guewen.baconnier&#64;camptocamp.com">guewen.baconnier&#64;camptocamp.com</a>&gt;</li>
 <li>Phuc Tran Thanh &lt;<a class="reference external" href="mailto:phuc&#64;trobz.com">phuc&#64;trobz.com</a>&gt;</li>
 <li>Sylvain LE GAL &lt;<a class="reference external" href="https://twitter.com/legalsylvain">https://twitter.com/legalsylvain</a>&gt;</li>
+<li>Jurgis Pralgauskis &lt;<a class="reference external" href="mailto:jurgis.pralgauskis&#64;gmail.com">jurgis.pralgauskis&#64;gmail.com</a>&gt;</li>


Usually we provide our @versada.eu email

Don't modify index.html. It is generated automatically.

yes, it is taken from CONTRIBUTORS.md, but I got Maciejs idea :)

maciej-wichowski · 2024-03-12T14:30:46Z

web_tree_dynamic_colored_field/README.rst

-      With this example, column which renders 'name' field will have its text colored in white on a customer records.
-
-  In the tree view declaration, use
-   ``options='"color_field": "my_color"'`` attribute in the ``tree``
-   tag:
-
-   ::
-
-      ...
-      <field name="arch" type="xml">
-          <tree string="View name" colors="color_field: my_color" >
-              ...
-              <field name="my_color" invisible="1"/>
-              ...
-          </tree>
-      </field>
-      ...
-
-  You can also use ``colors="bg_color_field: my_color"`` to defined the
-   field name that will be used for the background color of the line.


Why this example is removed?

I thought it refers to the deprecated functionality... (Oct 14, 2022)
https://github.com/OCA/web/blob/15.0/web_tree_dynamic_colored_field/readme/ROADMAP.rst
OCA@4b1f3fe

Now I noticed the removal was kind of "reverted" 3 days later (Oct 17, 2022)
OCA@9994bc6

So: 1) it is confusing, 2) we didn't use it in Siramis, and 3) I didn't want to spend time on this...
May be you have ideas how to handle this?

PS: whole JS code history: https://github.com/OCA/web/commits/15.0/web_tree_dynamic_colored_field/static/src/js/web_tree_dynamic_colored_field.js

Not sure why you need to touch this..:)

what do you mean by "this"?

if the docs part -- because I want docs to represent reality...

Well usually when we migrate OCA modules, we try to cover whole functionality, not only the one we need. Your PR might be rejected (not so bad, since we have our own branch).
So let's discuss. @oerp-odoo @DarkoNikolovski should we invest more time to migrate whole functionality?

If we can spare some time to properly migrate a module, then we should do it. Maybe @DarkoNikolovski can comment more on that:)

@dz0 Is it possible to migrate the missing part? If yes what would be the estimated time for that?

seems the functionality can't work, because of reason in ROADMAP.

tried on 17, the schema does not allow colors attr for tree

If not possible then let's continue as it is.
Wondering how it is working in v.15 or is it working at all, because I can't see colors there as well

dz0 · 2024-03-12T17:42:13Z

FYI, when pushing not migrated module to 17.0-versada, you should set "installable": False in __manifest__.py. Branch 17.0-versada is for our internal use, so if someone would add it into his project, Odoo would reject modules on init due to module version mismatch.

Ok, I will know,
but probably I can skip this in our case -- as noone ese uses 17.0-versada web yet, and before we merge migration...

dz0 · 2024-03-12T17:44:39Z

By the way,
is it ok, that I squashed quite some (auxilary) commits in history till 15.0 ?
(as it was recommended)

oerp-odoo · 2024-03-13T05:59:44Z

FYI, when pushing not migrated module to 17.0-versada, you should set "installable": False in __manifest__.py. Branch 17.0-versada is for our internal use, so if someone would add it into his project, Odoo would reject modules on init due to module version mismatch.

Why do we need to merge not migrated module? You could commit on your main branch yo reference your web branch you are working on, no need to merge anything to 17.0-versada before you migrate. Once it is migrated, then you can merge it here and switch in our monorepo as well.

oerp-odoo · 2024-03-13T06:01:16Z

web_tree_dynamic_colored_field/readme/CREDITS.md

@@ -1,3 +1,4 @@
 The development of this module has been financially supported by:

 - Camptocamp
+- Versada.eu


Suggested change

- Versada.eu

- Versada

oerp-odoo · 2024-03-13T06:02:14Z

web_tree_dynamic_colored_field/static/description/index.html

 </ul>
 </div>
 <div class="section" id="other-credits">
 <h1>Other credits</h1>
 <p>The development of this module has been financially supported by:</p>
 <ul class="simple">
 <li>Camptocamp</li>
+<li>Versada.eu</li>


Don't modify index.html for OCA modules, it is generated from rst files

Suggested change

<li>Versada.eu</li>

dz0 · 2024-03-13T08:46:50Z

FYI, when pushing not migrated module to 17.0-versada, you should set "installable": False in __manifest__.py. Branch 17.0-versada is for our internal use, so if someone would add it into his project, Odoo would reject modules on init due to module version mismatch.

Why do we need to merge not migrated module? You could commit on your main branch yo reference your web branch you are working on, no need to merge anything to 17.0-versada before you migrate. Once it is migrated, then you can merge it here and switch in our monorepo as well.

I thought then PR will be harder to track (and I didn't change any code "directly" in that "historical" part)....
But yews, we could select just commits with our changes for mine-changes review...

oerp-odoo · 2024-03-14T06:07:59Z

web_tree_dynamic_colored_field/static/description/index.html

@@ -515,7 +515,7 @@ <h1>Other credits</h1>
 <p>The development of this module has been financially supported by:</p>
 <ul class="simple">
 <li>Camptocamp</li>
-<li>Versada.eu</li>
+<li>Versada</li>


As I said, you must not edit index.html for OCA modules, this is generated automatically by OCA tools. You have to modify only rst files which index is generated from

hmm, I didn't -- pre-commit did 🤷

dz0 requested review from DarkoNikolovski and maciej-wichowski March 12, 2024 13:01

[MIG] web_tree_dynamic_colored_field: Migration to 17.0

a09db11

Implementation now is based on updating `style` attribute of `cell/td` instead of directly manipulating element's CSS value. Cleanup docs about no more implemented `colors` parameter for `tree`

dz0 force-pushed the feature-22921-mig-Colorize_field_in_tree_views-jpr branch from 4b4792b to a09db11 Compare March 12, 2024 13:09

maciej-wichowski approved these changes Mar 12, 2024

View reviewed changes

[FIX] PR suggestions 1

5f28b59

DarkoNikolovski requested review from oerp-odoo and removed request for DarkoNikolovski March 12, 2024 18:05

oerp-odoo reviewed Mar 13, 2024

View reviewed changes

[FIX] PR suggestions 2

4b20214

dz0 requested a review from oerp-odoo March 13, 2024 08:52

oerp-odoo reviewed Mar 14, 2024

View reviewed changes

oerp-odoo approved these changes Mar 14, 2024

View reviewed changes

dz0 merged commit 384ba04 into 17.0-versada Mar 14, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature 22921 mig colorize field in tree views jpr #4

Feature 22921 mig colorize field in tree views jpr #4

dz0 commented Mar 12, 2024

codecov bot commented Mar 12, 2024

maciej-wichowski left a comment

maciej-wichowski Mar 12, 2024

oerp-odoo Mar 13, 2024

dz0 Mar 13, 2024 •

edited

Loading

maciej-wichowski Mar 12, 2024

dz0 Mar 12, 2024 •

edited

Loading

oerp-odoo Mar 13, 2024

dz0 Mar 13, 2024

maciej-wichowski Mar 13, 2024

oerp-odoo Mar 13, 2024

DarkoNikolovski Mar 13, 2024

dz0 Mar 13, 2024

DarkoNikolovski Mar 13, 2024

dz0 commented Mar 12, 2024

dz0 commented Mar 12, 2024 •

edited

Loading

oerp-odoo commented Mar 13, 2024

oerp-odoo Mar 13, 2024

oerp-odoo Mar 13, 2024

dz0 commented Mar 13, 2024

oerp-odoo Mar 14, 2024

dz0 Mar 14, 2024

Feature 22921 mig colorize field in tree views jpr #4

Feature 22921 mig colorize field in tree views jpr #4

Conversation

dz0 commented Mar 12, 2024

codecov bot commented Mar 12, 2024

Welcome to Codecov 🎉

maciej-wichowski left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dz0 Mar 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dz0 Mar 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dz0 commented Mar 12, 2024

dz0 commented Mar 12, 2024 • edited Loading

oerp-odoo commented Mar 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dz0 commented Mar 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dz0 Mar 13, 2024 •

edited

Loading

dz0 Mar 12, 2024 •

edited

Loading

dz0 commented Mar 12, 2024 •

edited

Loading