-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surgery holosign, operating table console and stethoscope improvements #37133
base: Bleeding-Edge
Are you sure you want to change the base?
Surgery holosign, operating table console and stethoscope improvements #37133
Conversation
…omputers more synced up, improved computer/optable finding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm gonna be blunt. I'm not a fan of having an entire event and while(true) loop for each living mob for just their heart rate. It's just more CPU and code baggage for a mostly fluff benefit that can be implemented almost as well in a considerably cheaper way. (Having the machines/objects themselves check the mob on the timing of the last pulse detected when in use, and self-handle their targets having changing timing being one example.)
The manual holosign buttons would be great to keep around and likely expanded. What if you DON'T want the holosign to show you're doing surgery on someone? Perhaps that may be a switch on the button/console?
best i can do is bring the while loop to the operating tables and 'scopes instead, will that do?
brought them back just now |
did exactly this now anyways |
LGTM 👍 😸 💯 |
[content][sound]
What this does
makes the surgery holosigns automatically activate and deactivate when a patient is on the operating table
makes the operating table consoles do a beeping sound synced to the patients heartrate (including a flatline sound)
makes stethoscopes actually hear heartbeats in real time
Closes #37174.
Why it's good
realism, flavor, saves having to toggle the holosigns manually, makes it auto like morgues
How it was tested
putting a human on a surgery table near an operating computer, putting hyperzine in it to increase heartrate, calling death() on it, holding a stethoscope up to them, toggling NOBREATH on the block
Changelog
🆑