Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surgery holosign, operating table console and stethoscope improvements #37133

Open
wants to merge 29 commits into
base: Bleeding-Edge
Choose a base branch
from

Conversation

SECBATON-GRIFFON
Copy link
Contributor

@SECBATON-GRIFFON SECBATON-GRIFFON commented Sep 17, 2024

[content][sound]

What this does

makes the surgery holosigns automatically activate and deactivate when a patient is on the operating table
makes the operating table consoles do a beeping sound synced to the patients heartrate (including a flatline sound)
makes stethoscopes actually hear heartbeats in real time
Closes #37174.

Why it's good

realism, flavor, saves having to toggle the holosigns manually, makes it auto like morgues

How it was tested

putting a human on a surgery table near an operating computer, putting hyperzine in it to increase heartrate, calling death() on it, holding a stethoscope up to them, toggling NOBREATH on the block

Changelog

🆑

  • rscadd: Surgery room holosigns are now automatic, turning on and off if a patient is on an operating table or not. Turning them on with the holosign switch overrides this check, turning them off brings it back.
  • rscadd: Operating table computers now beep in sync with a patient's heartbeat and flatline when they die
  • rscadd: Stethoscopes now detect heartbeats in real time
  • rscadd: Stethoscopes no longer hear respiration on people with the no need to breathe mutation.

@D3athrow-Issues D3athrow-Issues added Content Adds something. Neat! Sound CAN YOU SMELELELELELEL labels Sep 17, 2024
@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as ready for review September 17, 2024 01:34
Copy link
Collaborator

@jwhitak jwhitak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna be blunt. I'm not a fan of having an entire event and while(true) loop for each living mob for just their heart rate. It's just more CPU and code baggage for a mostly fluff benefit that can be implemented almost as well in a considerably cheaper way. (Having the machines/objects themselves check the mob on the timing of the last pulse detected when in use, and self-handle their targets having changing timing being one example.)

The manual holosign buttons would be great to keep around and likely expanded. What if you DON'T want the holosign to show you're doing surgery on someone? Perhaps that may be a switch on the button/console?

@SECBATON-GRIFFON
Copy link
Contributor Author

SECBATON-GRIFFON commented Oct 1, 2024

I'm gonna be blunt. I'm not a fan of having an entire event and while(true) loop for each living mob for just their heart rate. It's just more CPU and code baggage for a mostly fluff benefit that can be implemented almost as well in a considerably cheaper way. (Having the machines/objects themselves check the mob on the timing of the last pulse detected when in use, and self-handle their targets having changing timing being one example.)

best i can do is bring the while loop to the operating tables and 'scopes instead, will that do?

The manual holosign buttons would be great to keep around and likely expanded. What if you DON'T want the holosign to show you're doing surgery on someone? Perhaps that may be a switch on the button/console?

brought them back just now

@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as draft October 3, 2024 00:07
@SECBATON-GRIFFON
Copy link
Contributor Author

best i can do is bring the while loop to the operating tables and 'scopes instead, will that do?

did exactly this now anyways

@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as ready for review October 3, 2024 00:16
@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as draft October 3, 2024 00:41
@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as ready for review October 3, 2024 15:15
@west3436 west3436 requested a review from jwhitak October 8, 2024 16:00
@brndd
Copy link
Contributor

brndd commented Jan 7, 2025

LGTM 👍 😸 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content Adds something. Neat! Sound CAN YOU SMELELELELELEL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

You can hear people breathing with a stethoscope if they have the NOBREATHE mutation
4 participants