Reverts the Roulette Revolver nerf (#35752)

[Eneocho]

What this does

Brings back the beloved TRUE roulette revolver by reverting #35752.

Why it's good

That PR? It was cringe. It brought no joy, and was merged despite a sizable contingent of players disliking it.

How it was tested

It wasn't, but I literally just undid the changes on the aforementioned PR
🆑

• tweak: Roulette Revolvers are back to their pre-nerf status, sans blob meteors and hookshots, those are still blocked.

[jwhitak]

Will not merge unless all hookshot types and subtypes remain blacklisted due to a rare server freezing error.

[jwhitak]

And as for my opinion, I'm not a fan of the PR as it stands. The nerf allows non antags to use the gun without risking getting banned for mass non antag murdering because an apoc meteor got shot out of it. Antags still have access to (most) of the game breaking stuff via spending TC to modify the revolver. It's at an ok spot.

Better buff ideas would be to (emag buff) switch the revolver modkit for just, say, an emag swipe, and allow a few more dangerous items on the list. Maybe even add the gun to the TC list formally? Though adding guns directly to the list is bad... I dunno, it feels like it's in a good spot now, so I'm stretching.

[MercuriusGH]

just add a wumbo mode toggle to the revolver

[brndd]

I'm going to shoot this in the hallways as a nonantag.

[SonixApache]

once again eneocho i suggest you filter your ideas through a class of elementary school children

if you get a single 'no', maybe actually make the PR

[Eneocho]

I just learned to tune out your complaints, Sonix. Does that count?

[west3436]

The entire reason Kurf buff/nerf'd this was because it was never used due to the inherent risk of blowing up the entire station outside of the extremely rare case where the antag xenoarch found one of these instead of just bringing an artifact on the station or emagging every door open. You can headcanon "le based nonantag scientist epically fighting the vampire but accidentally blowing up the entire station" all you want but ultimately this doesn't happen because people don't want to risk a ban for firing the silly gun.

[Eneocho]

Clearly that opinion is not shared by everyone, since there's a fair amount of people approving this PR.

[bathosbathtime]

Made a server poll: https://ss13.moe/index.php/poll/271

[Kurfursten]

I'm honestly disappointed in you as a collaborator Eneocho. I don't care about the PR itself, but this is not the example to set for future coders on how to write a "why it's good". You didn't justify it at all. In fact, it's an outright lie. This wasn't merged right before I left, it was a quarter of a year beforehand. And even if it was, are PRs good because I merged them right before leaving? Does #36269 need a revert?

The outcome for this PR doesn't matter: most rounds won't be affected by it. The most concerning thing is the day to day operations of the codebase. Please do some introspection, because it looks like your fellow collaborators aren't going to press you to improve.

[Eneocho]

The point I made in the Why It's Good section, as shitposty as may be, is valid, it was a lame change that got merged despite a lot of players not wanting it. On the whole selfmerge thing, I'm honestly very fussy on the timespan between you merging that and you leaving, life's been really blurry lately so it genuinely felt like you just did it then left soon after, thus, to my eyes, a controversial change got merged right before your departure. I see now I was mistaken, apologies for that (i'll change what the OP says), but I stand by my point of it being a change that, overall, was negative, even if you could use the gun more easily as a non-antag.