resolve comments for pr

Signed-off-by: Amory Hoste <[email protected]>
vhive-serverless · Dec 19, 2021 · d6e4a75 · d6e4a75
1 parent 63f16b2
commit d6e4a75
Show file tree

Hide file tree

Showing 2 changed files with 69 additions and 68 deletions.
diff --git a/proto/types.pb.go b/proto/types.pb.go
diff --git a/proto/types.proto b/proto/types.proto
@@ -98,12 +98,13 @@ message IPConfiguration {
 message FirecrackerMachineConfiguration {
 	string CPUTemplate = 1; // Specifies the cpu template. Example: "T2" or "C3"
 	bool HtEnabled = 2; // Specifies if hyper-threading should be enabled
-	bool TrackDirtyPages = 3; // Specified if dirty-page-tracking should be enabled.
 	 // Specifies the memory size of VM
 	 // This lets us create a Firecracker VM of up to 4096 TiB, which
 	 // for a microVM should be large enough
-	uint32 MemSizeMib = 4;
-	uint32 VcpuCount = 5; // Specifies the number of vCPUs for the VM
+	uint32 MemSizeMib = 3;
+	uint32 VcpuCount = 4; // Specifies the number of vCPUs for the VM
+	bool TrackDirtyPages = 5; // Specified if dirty-page-tracking should be enabled.
+
 }
 
 // Message to specify the block device config for a Firecracker VM