Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-9647] update 8mb partitions #370

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mattjperez
Copy link
Member

previous table left 1MB of space available, this recovers that and adds the coredump partition to micro-rdk-server

@mattjperez mattjperez self-assigned this Jan 2, 2025
@mattjperez mattjperez requested a review from a team as a code owner January 2, 2025 21:53
micro-rdk-server/esp32/ota_8mb_partitions.csv Outdated Show resolved Hide resolved
templates/project/partitions.csv Outdated Show resolved Hide resolved
micro-rdk-server/esp32/ota_8mb_partitions.csv Outdated Show resolved Hide resolved
micro-rdk-server/esp32/ota_8mb_partitions.csv Outdated Show resolved Hide resolved
micro-rdk-server/esp32/ota_8mb_partitions.csv Outdated Show resolved Hide resolved
micro-rdk-server/esp32/ota_8mb_partitions.csv Outdated Show resolved Hide resolved
@mattjperez mattjperez requested a review from acmorrow January 6, 2025 15:41
@acmorrow acmorrow requested a review from npmenard January 6, 2025 16:25
Copy link
Member

@acmorrow acmorrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I would like @npmenard to sign-off as well. Also interested in his thoughts on my alternative layout. I'll ping him on that thread.

@acmorrow
Copy link
Member

acmorrow commented Jan 8, 2025

@npmenard - During review of this, I came up with the following alternative partition ordering which seems to yield a much larger NVS partition, eliminates all gaps, and gives us the same OTA sizes. I'd be interested in your thoughts:

phy_init,      data,	      phy,	     0x9000,	0x1000,
coredump,      data,	      coredump,      0x10000, 	128K,
ota_0,	       0,	      ota_0,	     0x30000,	0x3e0000,
ota_1,	       0,	      ota_1,	     0x410000,	0x3e0000,
otadata,       data,	      ota,	     0x7f0000,	0x2000,
nvs,	       data,	      nvs,	     0x7f2000,  0xe000,

Also, I'd like us to decide what should happen to the regular partitions.csv, but I'm fine with that change coming as a subsequent PR in the interest of landing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants