[CONSULT-469] add initial code for field parsing #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvaradarajan
commented
Jan 8, 2025
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | ||
|
|
||
| [dependencies] | ||
| micro-rdk = { path = "../micro-rdk", features = ["native"] } |
There was a problem hiding this comment.
To my great annoyance, we've gone back to a state where micro-rdk cannot be built as a feature-less library. I'll make a ticket for this and link it here
EDIT: Ticket filed (https://viam.atlassian.net/browse/RSDK-9710)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of ~4 PRs for the NMEA 2000 parsing library. Introduces a macro for defining enums representing the various lookup fields present in messages and readers that parse specific data types from a byte slice. These readers will be used by the code generated with the proc macro appearing in the next PR.
Note: Going forward, to better visualize the code generated by the macros, I recommend using cargo expand (
cargo install cargo-expandto install,cargo expandto run) in the micro-rdk-nmea directory. You can use it in this PR to see how thelookupmacro expands but it will be more important in the subsequent PR introducing the proc macros