[RSDK-9458] Remove 'Stream' from Camera interface #4691
Conversation
…here we convert to go image; Change default mimetypes for classifier
…ng default mimetypes for vision since we are failing unit tests with 'do not know how to encode' errors
…urcewrappers Image func
Co-authored-by: nicksanford <[email protected]>
|
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
viambot
added
the
safe to test
viambot
added
safe to test
viambot
added
safe to test
| // StreamCamera is a camera that has `Stream` embedded to directly integrate with gostream. | ||
| // Note that generally, when writing camera components from scratch, embedding `Stream` is an anti-pattern. | ||
| type StreamCamera interface { | ||
| Camera | ||
| Stream(ctx context.Context, errHandlers ...gostream.ErrorHandler) (gostream.VideoStream, error) |
There was a problem hiding this comment.
this is meant to be removed in a follow up pr - affected drivers are transform, ffmpeg, fake, image_file and webcam
| Close(ctx context.Context) error | ||
| // StreamCamera is a camera that has `Stream` embedded to directly integrate with gostream. | ||
| // Note that generally, when writing camera components from scratch, embedding `Stream` is an anti-pattern. | ||
| type StreamCamera interface { |
There was a problem hiding this comment.
I can rename this to VideoSource - less of a break I think, even if the interface has changed.
That being said - the things that care about this struct still being a video source are set not to use Videsoruces in the (hopefully near) future.
| @@ -128,7 +111,8 @@ type Camera interface { | |||
| // err = myCamera.Close(context.Background()) | |||
| // | |||
| // [camera component docs]: https://docs.viam.com/components/camera/ | |||
| type VideoSource interface { | |||
| type Camera interface { | |||
There was a problem hiding this comment.
There's a lot of files changed here. Am I correct that these changes to VideoSource/Camera/StreamCamera are the only real changes and everything else is the refactor to appease the compiler?
There was a problem hiding this comment.
Kind of - in the process of deprecating Stream, different methods are being used in vision, and the stream server now takes context to refresh the streams - I can break up this pr into independent pieces and remove some of sean yu's renames to make it smaller, I do think this was the diff that made the most sense for his manual testing.
There was a problem hiding this comment.
The camera driver changes + the new StreamCamera interface (ffmpeg, transformpipeline, webcam) are there to appease the compiler without refactoring those drivers intensely.
The merge conflicts on Sean's PR will likely be terrible when he gets back in 2.5 weeks, so I'm using this branch to keep it recent.
I also think we're at a point where we can merge. I'm adding the original testing Sean did to the end of this comment.
Requests: @bhaney, could I have a config to test one of the vision services with to ensure
DecodeImageFromCameradoes not break them?Original PR + comment