Shellchecking #59
Merged
Shellchecking #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhxgit
force-pushed
the
shchk_debian.sh
branch
from
0472d7b to
b44940a
Compare
dhxgit
force-pushed
the
shchk_debian.sh
branch
3 times, most recently
from
d141dde to
2710de1
Compare
| # echo "DEVICES /dev/[hs]d*" > $FOLD/hdd$MDADMCONF | ||
| # execute_chroot_command "mdadm --detail --scan | sed -e 's/metadata=00.90/metadata=0.90/g' >> $MDADMCONF"; declare -i EXITCODE=$? | ||
| # echo "DEVICES /dev/[hs]d*" > $FOLD/hdd$MDADMCONF | ||
| # execute_chroot_command "mdadm --detail --scan | sed -e 's/metadata=00.90/metadata=0.90/g' >> $MDADMCONF"; declare -i EXITCODE=$? |
There was a problem hiding this comment.
should we remove this old stuff?
There was a problem hiding this comment.
at this point it is just about shellchecking, changing functionality has been avoided on purpose.
Additionally a vim-modeline was added. Also compare to Issue virtapi#6
dhxgit
force-pushed
the
shchk_debian.sh
branch
from
2710de1 to
b8df0cb
Compare
dhxgit
force-pushed
the
shchk_debian.sh
branch
from
b8df0cb to
96a1239
Compare
|
Apart from this one issue I'm happy with the commits except "Shellcheck'd debian.sh". This contains too many changes and I am not going to review it. |
Merged
|
👍 |
bastelfreak
merged commit 038c80c
into
virtapi:validate_scripts_with_shellcheck_issue_6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally a vim-modeline was added.
Also compare to Issue #6
Also improved the debian_grub_fix function #46