Release 2.3 (correction) (PR #39)

.github/workflows/maven.yml

@@ -15,7 +15,7 @@ on:
       - 'README.md'
   pull_request:
     branches: develop
-env:
+env: # beware env value are of string type, not boolean. Need to use fromJSON to convert them to boolean
   isProduction: ${{ github.event_name == 'push' && github.ref_name == 'master' }}
   prepareRelease: ${{ github.event_name == 'push' && github.ref_name == 'develop' && contains(github.event.head_commit.message, 'prepare release') }}
 
@@ -31,7 +31,7 @@ jobs:
         java-version: '11'
         distribution: 'temurin'
         cache: maven
-        server-id: ${{ (env.isProduction == true && 'creatis-releases') || 'creatis-snapshots' }}
+        server-id: ${{ (fromJSON(env.isProduction) && 'creatis-releases') || 'creatis-snapshots' }}
         server-username: MAVEN_USERNAME
         server-password: MAVEN_PASSWORD
     - name: Build with Maven
@@ -40,7 +40,7 @@ jobs:
       env:
         MAVEN_USERNAME: github
         MAVEN_PASSWORD: ${{ secrets.NEXUS_PSW }}
-        mavenTarget: ${{ github.event_name == 'push' && env.prepareRelease == false && 'deploy' || 'verify' }}
+        mavenTarget: ${{ github.event_name == 'push' && ! fromJSON(env.prepareRelease) && 'deploy' || 'verify' }}
     - name: Publish Test Report
       uses: mikepenz/action-junit-report@v3
       with: