-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rearrange DOM to fix widget events in all environments #8893
Open
chrisgervang
wants to merge
109
commits into
master
Choose a base branch
from
chr/rearrange-widget-dom
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Gervang <[email protected]>
* Update learning-resources.md * update slack link
* feat(carto): Support .tileSize prop in H3Tileset2D * chore(carto): Add tests for QuadbinTileset2D getTileZoom @ tileSize
Co-authored-by: Chris Gervang <[email protected]>
* feat(pydeck): Update to Deck v9 * feat(pydeck-carto): Add new CARTO layers, sources, and auth flow (#8791, #8806) --------- Co-authored-by: Don McCurdy <[email protected]>
* remove container from zoom-widget docs * add export for @deck.gl/widgets stylesheet
Signed-off-by: Chris Gervang <[email protected]>
chrisgervang
commented
May 14, 2024
Signed-off-by: Chris Gervang <[email protected]>
Signed-off-by: Chris Gervang <[email protected]>
chrisgervang
changed the title
Chr/rearrange widget dom
Rearrange DOM to fix widget events in all environments
May 19, 2024
@@ -1007,9 +1009,13 @@ export default class Deck<ViewsT extends ViewOrViews = null> { | |||
|
|||
this.deckPicker = new DeckPicker(this.device); | |||
|
|||
const parent = this.props.parent || document.body; | |||
const widgetParent = | |||
parent.querySelector<HTMLDivElement>('.deck-widgets-container') || this.canvas?.parentElement; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be this.props.parent?.querySelector()
like the eventRoot
? Searching under document.body
is suspicious...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8877
Background
Exploring a way to exclude widgets from the deck event manager and push it above maplibre. Currently mouse event on a widget performs deck picking, which is an unwanted interaction.
propagation_short.mov
Rearranging the DOM so that the deck picker and widgets are peer elements fix the deck picking issue. Also, by nesting the deck children, such as react-map-gl in reversed controlled configuration, the deck widgets events aren't blocked by maplibre.
react-widget-dom.mov
Flavors to test:
Change List
parent
, selects an.event-manager-root
element for EventManager to use for picking.parent
, selects an.deck-widgets-container
element for WidgetManager to add widgets to.<DeckGL/>
children under.event-manager-root
.deck-widgets-container