CARTO: QuadbinHeatmapTileLayer docs #8909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
approved these changes
May 20, 2024
|
|
||
| Controls how weight values are mapped to the `colorRange`, as an array of two numbers [`minValue`, `maxValue`]. | ||
|
|
||
| When `colorDomain` is specified, a pixel with `minValue` is assigned the first color in `colorRange`, a pixel with `maxValue` is assigned the last color in `colorRange`, and any value in between is linearly interpolated. Pixels with weight less than `minValue` gradually fade out by reducing alpha, until 100% transparency representing `0`. Pixels with weight more than `maxValue` are capped to the last color in `colorRange`. |
There was a problem hiding this comment.
and any value in between is linearly interpolated.
Perhaps just "any value in between is interpolated"? I'm probably overthinking it, but I could see this implying interpolation in a linear color space, which the layer currently does not do.
... until 100% transparency representing
0
Given a signed colorDomain like [-100, 100], I wouldn't be sure how to interpret this... if full transparency represents zero, perhaps something should be said about interpolation between the domain minimum and zero?
There was a problem hiding this comment.
The description was wrong, I've corrected it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation update for #8703