-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website: Maplibre globe example #9293
base: master
Are you sure you want to change the base?
Conversation
3fe3bc3
to
2f8996f
Compare
The text support in this globe basemap is amazing 🤩 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in a bunch of places made things a bit confusing to review, but overall LGTM.
@@ -5,6 +5,27 @@ | |||
import {ArcLayer, ArcLayerProps} from '@deck.gl/layers'; | |||
import {Accessor, DefaultProps} from '@deck.gl/core'; | |||
|
|||
import type {ShaderModule} from '@luma.gl/shadertools'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, this layer could maybe be nice to publish in deck.gl-community/layers or /experimental modules?
7e05458
to
a53f4d2
Compare
#9296 adds interleaved support, holding off further work here until that is merged |
For #9199 holding off further work until #9296 is merged
Background
Adds a new website example for Maplibre Globe. This will not replace the existing example, but I've based it off it to make the code easier to review. Prior to merging we would create a new example and integrate into website
Screen.Recording.2024-12-11.at.15.19.26.mov
Change List