Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: Maplibre globe example #9293

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

felixpalmer
Copy link
Collaborator

@felixpalmer felixpalmer commented Dec 11, 2024

For #9199 holding off further work until #9296 is merged

Background

Adds a new website example for Maplibre Globe. This will not replace the existing example, but I've based it off it to make the code easier to review. Prior to merging we would create a new example and integrate into website

Screen.Recording.2024-12-11.at.15.19.26.mov

Change List

  • Conversion of old code to UBO
  • Addition of Maplibre globe & removal of GeoJsonLayer
  • Style tweaks

Base automatically changed from x/globe-view to master December 11, 2024 18:47
@chrisgervang
Copy link
Collaborator

The text support in this globe basemap is amazing 🤩

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in a bunch of places made things a bit confusing to review, but overall LGTM.

@@ -5,6 +5,27 @@
import {ArcLayer, ArcLayerProps} from '@deck.gl/layers';
import {Accessor, DefaultProps} from '@deck.gl/core';

import type {ShaderModule} from '@luma.gl/shadertools';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, this layer could maybe be nice to publish in deck.gl-community/layers or /experimental modules?

modules/core/src/viewports/globe-viewport.ts Outdated Show resolved Hide resolved
modules/core/src/viewports/globe-viewport.ts Outdated Show resolved Hide resolved
@felixpalmer
Copy link
Collaborator Author

#9296 adds interleaved support, holding off further work here until that is merged

@coveralls
Copy link

coveralls commented Dec 13, 2024

Coverage Status

coverage: 91.675%. remained the same
when pulling dbe5d75 on felix/maplibre-globe-example
into 2ba7157 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants