Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: I3S example, disable texture compression #9341

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

felixpalmer
Copy link
Collaborator

For #9056

@ibgreen is it expected that compressed textures are not working? Without this "fix", I see errors like:

WebGL: INVALID_OPERATION: texSubImage2D: ArrayBufferView not big enough for requestUnderstand this warningAI
WebGL: INVALID_VALUE: texSubImage2D: width or height out of range

Repro https://felixpalmer.github.io/deck.gl/examples/arcgis

Change List

  • {useCompressedTextures: false}

@felixpalmer felixpalmer mentioned this pull request Jan 8, 2025
45 tasks
@coveralls
Copy link

coveralls commented Jan 8, 2025

Coverage Status

coverage: 91.671%. remained the same
when pulling c28930b on felix/v9-website-i3s-fix
into 564d294 on master.

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it expected that compressed textures are not working?

No... this may be a side effect of the texture refactors. Should check that we have test cases for compressed textures in luma.gl.

@belom88 FYI

@felixpalmer felixpalmer merged commit f8fcf3c into master Jan 13, 2025
2 checks passed
@felixpalmer felixpalmer deleted the felix/v9-website-i3s-fix branch January 13, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants