fix(engine): ShaderInputs ignore props with disableWarnings (#2314)

visgl · Jan 9, 2025 · 65d5e14 · 65d5e14
1 parent 8befd5e
commit 65d5e14
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/modules/engine/src/shader-inputs.ts b/modules/engine/src/shader-inputs.ts
@@ -90,9 +90,11 @@ export class ShaderInputs<
       const moduleName = name as keyof ShaderPropsT;
       const moduleProps = props[moduleName] || {};
       const module = this.modules[moduleName];
-      if (!module && !this.options.disableWarnings) {
+      if (!module) {
         // Ignore props for unregistered modules
-        log.warn(`Module ${name} not found`)();
+        if (!this.options.disableWarnings) {
+          log.warn(`Module ${name} not found`)();
+        }
         continue; // eslint-disable-line no-continue
       }