Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gltf): new module for glTF support #1819

Merged
merged 46 commits into from
Nov 29, 2023
Merged

feat(gltf): new module for glTF support #1819

merged 46 commits into from
Nov 29, 2023

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Oct 13, 2023 •
edited
Loading

For #

Background

  • This was the start of an attempt to move the gltf code from the deprecated experimental module into a dedicated @luma.gl/gltf module.
  • Also started refactor the dated APIs.

Change List

  • Scaffolds a new gltf module
  • Renames GLTFMaterial to PBRMaterial and flattens it into a pure JS structure (not a class).
  • Renames GLTFEnvironment to PBREnvironment and tries to simplify it
  • ...

@ibgreen ibgreen requested a review from felixpalmer October 13, 2023 12:31
ibgreen
ibgreen commented Nov 28, 2023
View reviewed changes
Copy link
Collaborator Author

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing, thanks for making this effort!

Added suggestions but nothing that has to be fixed before landing.

  • Restore some minimal tests,
  • create a task with some potential followups
  • then land.

modules/engine/src/geometry/gpu-geometry.ts Outdated Show resolved Hide resolved
modules/gltf/src/gltf/create-gltf-model.ts Outdated Show resolved Hide resolved
modules/gltf/src/gltf/gltf-instantiator.ts Show resolved Hide resolved
website/package.json Show resolved Hide resolved
modules/gltf/src/gltf/gltf-instantiator.ts Outdated Show resolved Hide resolved
modules/gltf/package.json Outdated Show resolved Hide resolved
examples/tutorials/hello-gltf/app.ts Outdated Show resolved Hide resolved
examples/tutorials/hello-gltf/app.ts Show resolved Hide resolved
examples/tutorials/hello-gltf/vite.config.ts Outdated Show resolved Hide resolved
modules/gltf/src/index.ts Outdated Show resolved Hide resolved
@ibgreen ibgreen marked this pull request as ready for review November 28, 2023 14:32
@felixpalmer felixpalmer mentioned this pull request Nov 28, 2023
Closed
7 tasks
@felixpalmer felixpalmer mentioned this pull request Nov 29, 2023
Open
10 tasks
@felixpalmer felixpalmer merged commit c183409 into master Nov 29, 2023
2 checks passed
@felixpalmer felixpalmer deleted the ib/gltf branch November 29, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixpalmer felixpalmer Awaiting requested review from felixpalmer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibgreen @felixpalmer