Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine): Disable warnings in ShaderInputs #2300

Merged
merged 4 commits into from
Dec 13, 2024
Merged

fix(engine): Disable warnings in ShaderInputs #2300

merged 4 commits into from
Dec 13, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Dec 12, 2024 •
edited
Loading

For #

Background

  • deck.gl gets excessive warnings for intentional usage

Change List

  • disableWarnings flag on ShaderInputs, pass down from Model
  • Somehow the typings are starting to act up, didn't have time to dig in, changed some expect-errors to ignore

@ibgreen ibgreen changed the title fix(engine): Disable wwarings in shaderInputs fix(engine): Disable warinngs in shaderInputs Dec 12, 2024
@ibgreen ibgreen changed the title fix(engine): Disable warinngs in shaderInputs fix(engine): Disable warnings in ShaderInputs Dec 12, 2024
@ibgreen ibgreen merged commit 1ff0ace into master Dec 13, 2024
2 checks passed
@ibgreen ibgreen deleted the ib/shader-input-warnings branch December 13, 2024 14:49
ibgreen added a commit that referenced this pull request Dec 13, 2024
@ibgreen
feat(engine): Option to disable warnings in ShaderInputs (#2300)
f31e638
@ibgreen ibgreen mentioned this pull request Dec 13, 2024
Merged
@felixpalmer felixpalmer mentioned this pull request Jan 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ibgreen