Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-vite): add Marko #19257

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

LuLaValva
Copy link

Changes

  • Add Marko to the list of frameworks in create-vite
  • Create marko and marko-ts examples

Concerns / Discussion Items

  • We crossed a threshold, and the prompts select doesn't show all options at once anymore 🙈
    image
  • Most of the other starters have a tsconfig.node.json specifically for vite.config.ts. We aligned with Lit and moved to a single tsconfig.json for the entire project
  • Right now the examples are using a Marko 6 prerelease version ("^6.0.0-next.3.22"), so there are known bugs and updates will be frequent. It might make sense to hold off on merging this until we publish ^6.0.0

@patak-dev
Copy link
Member

Quite a milestone to surpass the threshold! This looks good to me, thanks @LuLaValva! I think it is a good idea as you suggest to wait for the Marko v6 release. Do you have an ETA for it?

@LuLaValva
Copy link
Author

Thanks for the quick review @patak-dev! We're not certain of the ETA yet, but we're hoping for a stable release in the next few months. I'll update this branch and ping again once we've published the major version.

@patak-dev
Copy link
Member

Good luck with the release! Looking forward to Marko being in create-vite 🎉

@patak-dev patak-dev added the feat: create-vite create-vite package label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: create-vite create-vite package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(create-vite): Add Marko
2 participants