CI: fix to Online DDL flow test, do not t.Log from within a goroutine #17496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quick fix to Online DDL flow test flakiness, caused to to logging in a goroutine. We can add more synchronization to ensure the logging is only ever done while the tests is still running, but then again this logging is for convenience only. Switched to
fmt.Println
instead, it's just as informative.Related Issue(s)
https://github.com/vitessio/vitess/actions/runs/12676221410/job/35328963706?pr=17443
Checklist
Deployment Notes