-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Qtip Library with Floating ui #3937
Open
milospp
wants to merge
21
commits into
vivo-project:main
Choose a base branch
from
milospp:fix-tooltip
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
d59c367
fix: css for login width, inline form labels, site admin menu, data p…
milospp 409ba98
Replaced Qtip with Popper and bootstrap
milospp b4b82a8
Remove Qtip from ViSCommonControl is map of science
milospp 6d71b1e
Fixed popper for Vitro, Nemo and Tenderfoot themes
milospp 03da66e
Fixed tooltip design
milospp 10c0a9e
Moved the repeated inline style to the class
milospp 764eb2c
Removed !important tags
milospp 8b7067d
Removed !important in .show class
milospp 6356b62
Created tooltip css for everytheme to reduce reduntant code
milospp 612589f
Refactored code
milospp d452653
Renaming vivoTooltip to vitroTooltip
milospp 6d1aee5
Removed bootstrap
milospp a84b1c8
excluded bootstrap from popper
milospp a5570c5
Revert wilma changes
milospp 486e5da
Refactored code
milospp 699386e
fix: Vitro theme bug
milospp 63466e5
Removed bootstrap 5 dependency
milospp d0b57b6
Removed unrelated changes
milospp 0e248f5
Migraiton popper to floating
milospp d0a8e44
Fixed clipped qr code popover in tenderfoot theme
milospp 7053402
Removed unnecessary css
milospp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83 changes: 0 additions & 83 deletions
83
webapp/src/main/webapp/js/individual/individualQtipBubble.js
This file was deleted.
Oops, something went wrong.
37 changes: 37 additions & 0 deletions
37
webapp/src/main/webapp/js/individual/individualTooltipBubble.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/* $This file is distributed under the terms of the license in LICENSE$ */ | ||
|
||
$(document).ready(function(){ | ||
$.extend(this, i18nStrings); | ||
|
||
let tooltips = [ | ||
{ | ||
querySelector: "#researchAreaIcon", | ||
data: { | ||
title: "<div>" + i18nStrings.researchAreaTooltipOne + "</div><div>" + i18nStrings.researchAreaTooltipTwo + "</div>", | ||
placements: ['top', 'right', 'bottom', 'left'], | ||
customClass: "vitroTooltip" | ||
} | ||
}, | ||
{ | ||
querySelector: "#fullViewIcon", | ||
data: { | ||
title: i18nStrings.quickviewTooltip, | ||
placements: ['top', 'right', 'bottom', 'left'], | ||
customClass: "vitroTooltip" | ||
} | ||
}, | ||
{ | ||
querySelector: "#quickViewIcon", | ||
data: { | ||
title: "<div>" + i18nStrings.standardviewTooltipOne + '</div><div>' + i18nStrings.standardviewTooltipTwo + "</div>", | ||
placements: ['top', 'right', 'bottom', 'left'], | ||
customClass: "vitroTooltip" | ||
} | ||
}, | ||
] | ||
|
||
tooltips.forEach(tooltip => { | ||
setTooltip(tooltip.querySelector, tooltip.data) | ||
}) | ||
|
||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it needed? Seems like the same css as in webapp/src/main/webapp/css/visualization/mapofscience/layout.css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
webapp/src/main/webapp/css/visualization/mapofscience/layout.css
This CSS is loaded only in Vitro theme and
webapp/src/main/webapp/themes/nemo/css/layout.css
this CSS is loaded only in the Nemo theme
so this should be in both file