Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIVO-3992 Reversed order of URL type options #3999

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

litvinovg
Copy link
Collaborator

VIVO GitHub issue

What does this pull request do?

Sets URL as default URL Type by reversion options order.

How should this be tested?

  • Reproduce the problem in the issue
  • Test that the pull request fixes the issue

Interested parties

@VIVO-project/vivo-committers

Reviewers' expertise

  1. FreeMarker

Reviewers' report template

General comment

A reviewer should provide here comments and suggestions for requested changes if any.

Testing

A reviewer should briefly describe here how it was tested

Code reviewing

A reviewer should briefly describe here which part was code reviewed

Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment

Works as it is expected. URL is a default web site type.

Testing

I have tested web site at the example of a person profile page.

Code reviewing

Don't have complaints on the code.

@brianjlowe brianjlowe merged commit d82b8f7 into vivo-project:main Sep 12, 2024
4 checks passed
@chenejac chenejac linked an issue Nov 5, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default for new Link should be "URL" instead of "Faculty of 1000 Link"
3 participants