-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Validate lora adapters to avoid crashing server #11727
Conversation
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Very useful feature! I will review this PR asap . Thanks! |
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution, overall LGTM
This PR addresses an issue where loading an invalid lora adapter will crash the engine and shut the server down. This happens because dynamically loaded adapters are first loaded just-in-time, during model execution. Invalid adapters will raise at load time, and any exceptions raised during model execution will shut down the engine and the server.
Instead, this PR updates the
/v1/load_lora_adapter
handler to first callengine.add_lora
to ensure that the adapter can be successfully loaded. On error, the adapter is not added to the list of available models to use. This should result in a better user experience, as users will immediately know if there is a problem with their adapter when they try to load it, instead of having it crash their server later when they try to use it.FIX #11702