Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: maliit-keyboard #52107

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hervyqa
Copy link
Contributor

@hervyqa hervyqa commented Sep 4, 2024

Maybe fix: #49597

Screenshot_20240904_123308

Testing the changes

  • I tested the changes in this PR: YES, but maliit virtual keyboard still not working. any advice @classabbyamp ?
Operating System: Void 
KDE Plasma Version: 6.1.4
KDE Frameworks Version: 6.5.0
Qt Version: 6.7.2
Kernel Version: 6.6.48_1 (64-bit)
Graphics Platform: Wayland
Processors: 12 × Intel® Core™ i5-10500H CPU @ 2.50GHz
Memory: 23.3 GiB of RAM
Graphics Processor: Mesa Intel® UHD Graphics
Manufacturer: Micro-Star International Co., Ltd.
Product Name: GF63 Thin 10UC
System Version: REV:1.0

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64)

@hervyqa hervyqa force-pushed the maliit-keyboard branch 10 times, most recently from 19ec96f to 11b771d Compare September 4, 2024 12:27
@hervyqa
Copy link
Contributor Author

hervyqa commented Sep 4, 2024

I have added the parameter -DWaylandScanner_EXECUTABLE=/usr/bin/wayland-scanner but for arm architecture it still gives error.

-- Found WaylandProtocols: /usr/aarch64-linux-gnu/usr/share/wayland-protocols
CMake Error at /usr/libexec/xbps-src/share/cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
  Could NOT find QtWaylandScanner (missing: QtWaylandScanner_EXECUTABLE)
Call Stack (most recent call first):
  /usr/libexec/xbps-src/share/cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)
  cmake/FindQtWaylandScanner.cmake:76 (find_package_handle_standard_args)
  CMakeLists.txt:48 (find_package)
-- Configuring incomplete, errors occurred!
=> ERROR: maliit-framework-2.3.0_1: do_configure: 'CFLAGS="-DNDEBUG ${CFLAGS/ -pipe / }" CXXFLAGS="-DNDEBUG ${CXXFLAGS/ -pipe / }" cmake ${cmake_args} ${configure_args} ${LIBS:+-DCMAKE_C_STANDARD_LIBRARIES="$LIBS"} ${LIBS:+-DCMAKE_CXX_STANDARD_LIBRARIES="$LIBS"} ${wrksrc}/${build_wrksrc}' exited with 1
=> ERROR:   in do_configure() at common/build-style/cmake.sh:77

@Duncaen
Copy link
Member

Duncaen commented Sep 4, 2024

Haven't tested it but its asking for QtWaylandScanner_EXECUTABLE, you seem to miss the Qt prefix.

@classabbyamp classabbyamp added the new-package This PR adds a new package label Sep 4, 2024
@hervyqa hervyqa force-pushed the maliit-keyboard branch 2 times, most recently from d34e5b2 to 37c2548 Compare September 5, 2024 01:49
@hervyqa
Copy link
Contributor Author

hervyqa commented Sep 5, 2024

my bad. i didn't add qt5-wayland to hostmakedepend. build succeeded, but virtual-keyboard still doesn't show up.

Copy link

github-actions bot commented Dec 5, 2024

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Dec 5, 2024
@github-actions github-actions bot closed this Dec 20, 2024
@Anachron
Copy link
Contributor

Anachron commented Jan 9, 2025

I've installed this on KDE plasma and it works reasonably well. I just dislike that it has no ctrl, alt etc keys, but that's going to be possible with maliit/keyboard#236.

@hervyqa
Copy link
Contributor Author

hervyqa commented Jan 10, 2025

I haven't succeeded in displaying maliit-keyboard. Can I get the maliit-keyboard screenshot? @Anachron

@Anachron
Copy link
Contributor

Anachron commented Jan 10, 2025

@hervyqa Yeah sure, here is a terminal example (de keyboard layout, Ambiance theme):

maliit

Edit: It was actually the Ambiance Themen.

@Anachron
Copy link
Contributor

Will you reopen this or should I create my own PR?
I dont see anything wrong with it. It works as expected.
If you have problems with it showing up, its not related to this package and we can debug it on IRC.

@hervyqa hervyqa changed the title DRAFT: New package: maliit-keyboard New package: maliit-keyboard Jan 11, 2025
@hervyqa
Copy link
Contributor Author

hervyqa commented Jan 11, 2025

Will you reopen this or should I create my own PR?

I'm sorry @Anachron, i can't reopen this PR. only admin can change it. cc: @classabbyamp

@classabbyamp classabbyamp reopened this Jan 11, 2025
@github-actions github-actions bot removed the Stale label Jan 12, 2025
@Anachron

This comment was marked as off-topic.

@hervyqa hervyqa reopened this Jan 13, 2025
@hervyqa hervyqa marked this pull request as ready for review January 13, 2025 06:52
@hervyqa
Copy link
Contributor Author

hervyqa commented Jan 13, 2025

rebase. ready for review. @Anachron @classabbyamp

@the-maldridge
Copy link
Member

Something went wrong with your rebase and the -doc package is now broken. Please fix and re-push.

@Anachron
Copy link
Contributor

Finally, all is well! Very nice.
I've recompiled it and confirmed on my StarLabs StarLite MK V that this indeed works as expected on x86_64-glibc.

@classabbyamp
Copy link
Member

please stop pinging me in this thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: Maliit Keyboard
5 participants