Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radicale: update to 3.4.0. #53225

Merged
merged 2 commits into from
Jan 12, 2025
Merged

radicale: update to 3.4.0. #53225

merged 2 commits into from
Jan 12, 2025

Conversation

jason1987d
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64-libc

@jason1987d jason1987d changed the title radicale: update to 3.3.1. radicale: update to 3.3.2. Dec 15, 2024
@jason1987d jason1987d changed the title radicale: update to 3.3.2. radicale: update to 3.3.3. Jan 1, 2025
@jason1987d
Copy link
Contributor Author

I apologize for the failed tests, will get a commit with a template for pika as well shortly.

@jason1987d jason1987d force-pushed the radicale branch 3 times, most recently from a3f2710 to 285a127 Compare January 1, 2025 03:50
revision=1
build_style=python3-pep517
hostmakedepends="python3-setuptools"
depends="python3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package ships tests; can they be run by ./xbps-src check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=> radicale-3.3.3_1: running do_check ...
============================= test session starts ==============================
platform linux -- Python 3.13.1, pytest-8.3.1, pluggy-1.5.0
rootdir: /builddir/radicale-3.3.3
configfile: pyproject.toml
plugins: flake8-1.1.1, cov-5.0.0
collected 202 items

radicale/tests/test_auth.py ...................................          [ 17%]
radicale/tests/test_base.py ............................................ [ 39%]
.......................................................                  [ 66%]
radicale/tests/test_config.py ...............                            [ 73%]
radicale/tests/test_expand.py ....                                       [ 75%]
radicale/tests/test_rights.py ...........                                [ 81%]
radicale/tests/test_server.py .......                                    [ 84%]
radicale/tests/test_storage.py ............................              [ 98%]
radicale/tests/test_web.py ...                                           [100%]

=============================== warnings summary ===============================
radicale/tests/test_base.py: 96 warnings
radicale/tests/test_expand.py: 8 warnings
radicale/tests/test_storage.py: 16 warnings
  /builddir/radicale-3.3.3/radicale/app/report.py:174: DeprecationWarning: Testing an element's truth value will always return True in future versions.  Use specific 'len(elem)' or 'elem is not None' test instead.
    props: Union[ET.Element, List] = root.find(xmlutils.make_clark("D:prop")) or []

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
====================== 202 passed, 120 warnings in 6.76s =======================

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's radicale. The new python3-pika should pull in pytest and run checks unless there is a compelling reason to skip them.

Copy link
Contributor Author

@jason1987d jason1987d Jan 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I might need to edit something in do_check step. Something cannot find a tests module.

__________ ERROR collecting tests/unit/threaded_test_wrapper_test.py ___________
ImportError while importing test module '/builddir/python3-pika-1.3.2/tests/unit/threaded_test_wrapper_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python3.13/importlib/__init__.py:88: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/unit/threaded_test_wrapper_test.py:15: in <module>
    from tests.wrappers import threaded_test_wrapper
E   ModuleNotFoundError: No module named 'tests'
=========================== short test summary info ============================
ERROR tests/acceptance/blocking_adapter_test.py
ERROR tests/unit/io_services_test_stubs_test.py
ERROR tests/unit/threaded_test_wrapper_test.py
!!!!!!!!!!!!!!!!!!! Interrupted: 3 errors during collection !!!!!!!!!!!!!!!!!!!!
============================== 3 errors in 0.43s ===============================
=> ERROR: python3-pika-1.3.2_1: do_check: 'PATH="${testdir}/usr/bin:${PATH}" PYTHONPATH="${testdir}/${py3_sitelib}" PY_IGNORE_IMPORTMISMATCH=1 ${make_check_pre} pytest3 ${testjobs} ${make_check_args} ${make_check_target}' exited with 2
=> ERROR:   in do_check() at common/build-style/python3-pep517.sh:36
[jason@box void-packages]$ ls masterdir/builddir/python3-pika-1.3.2/
CHANGELOG.md     MANIFEST.in  dist       pika            test-requirements.txt
CONTRIBUTING.md  README.rst   docs       pika.egg-info   testdata
HISTORY.md       RELEASE.md   examples   pylintrc        tests
LICENSE          build        nose2.cfg  pyproject.toml  utils
[jason@box void-packages]$ ls masterdir/builddir/python3-pika-1.3.2/tests
acceptance  base  misc  stubs  unit  wrappers
[jason@box void-packages]$ ls masterdir/builddir/python3-pika-1.3.2/tests/base
__init__.py  async_test_base.py

I did add all the dependencies to checkdepends (including python3-pytest), except attempting to track down distfiles for this bizarre 'codecov' module...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, when switching to the pypi tarball as requested in the bottom comment...

=> python3-pika-1.3.2_1: running do_check ...                                         
============================= test session starts ==============================      
platform linux -- Python 3.13.1, pytest-8.3.1, pluggy-1.5.0                           
rootdir: /builddir/python3-pika-1.3.2                                                 
configfile: pyproject.toml                                                            
collected 0 items                                                                     
                                                                                      
============================ no tests ran in 0.01s =============================      
=> ERROR: python3-pika-1.3.2_1: do_check: 'PATH="${testdir}/usr/bin:${PATH}" PYTHONPAT
H="${testdir}/${py3_sitelib}" PY_IGNORE_IMPORTMISMATCH=1 ${make_check_pre} pytest3 ${t
estjobs} ${make_check_args} ${make_check_target}' exited with 5                       
=> ERROR:   in do_check() at common/build-style/python3-pep517.sh:36

srcpkgs/python3-pika/template Outdated Show resolved Hide resolved
@jason1987d jason1987d force-pushed the radicale branch 2 times, most recently from 250e389 to 9138218 Compare January 5, 2025 18:53
@ahesford
Copy link
Member

ahesford commented Jan 5, 2025

python3-nose is a removed package, and the version still in the repositories won't function with Python 3.13 anyway.

@jason1987d
Copy link
Contributor Author

python3-nose is a removed package, and the version still in the repositories won't function with Python 3.13 anyway.

Best course of action then? Set make_check=no for pika for this reason?

@jason1987d jason1987d changed the title radicale: update to 3.3.3. radicale: update to 3.4.0. Jan 12, 2025
@jason1987d
Copy link
Contributor Author

jason1987d commented Jan 12, 2025

At this point, I have set make_check=no for pika due to the nose dependency issues. radicale (now 3.4.0) itself tests and also runs just fine, I updated it on my own system and have been using it. I changed the source on the distfiles for pika to pypi_site as well.

@ahesford ahesford merged commit 40cde83 into void-linux:master Jan 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants