Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TargetWithStatus field to DependOn struct for job creation based on specific status #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhaizhch
Copy link

  • Introduced a new field TargetWithStatus in the DependOn struct.
  • This field enables the creation of new jobs based on the specified status of a dependent job.
    TODO in volcano:
  • Updated relevant logic to incorporate the new field for job dependency management.
  • Added tests to verify the behavior of TargetWithStatus in different scenarios.

This enhancement improves the flexibility of job dependency handling by supporting conditional job creation based on status.

@volcano-sh-bot
Copy link
Collaborator

Welcome @zhaizhch!

It looks like this is your first PR to volcano-sh/apis.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot requested a review from k82cn January 22, 2025 06:58
@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign wpeng102
You can assign the PR to them by writing /assign @wpeng102 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhaizhch
Copy link
Author

/assign @wpeng102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants