Minor updates to Materials CSV Source #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitabarskov
force-pushed
the
nikita.barskov-20240408T231713-update-asynchronous-csv-source
branch
2 times, most recently
from
e2bf74a to
b38d1f4
Compare
- Move `MaterialsSource` to `csv/base.py` because we don't have any others implementations so far, - Update types in annotations, - Add `delimiter` field to CSV Source (we can expect a customer using tabs, commas and etc), - Add additional validation logic when reading a file (a read will fail if a file does not contain a required column), - Minor improvements and test changes.
nikitabarskov
force-pushed
the
nikita.barskov-20240408T231713-update-asynchronous-csv-source
branch
from
b38d1f4 to
aafceb9
Compare
Happycoil
approved these changes
Apr 9, 2024
nikitabarskov
deleted the
nikita.barskov-20240408T231713-update-asynchronous-csv-source
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes minor changes to Materials CSV source
mypypasses,volur.sdk.sourcesfolder,delimiterto a CSV Source, because we expect customers to use different delimiters in theirs CSV,poetry.lock.