possible fix for the ULongArray issue and for mode_t portability #143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This won't compile on my computer, possibly due to some kind of version mismatch issue:
But there's at least a chance this might work for you. Please check it out. Of note, I think I've got a portable solution to the
mode_t
issue, and I moved everything fromULongArray
toLongArray
and the compiler at least seems to be happy with that. It shouldn't make a difference (fingers crossed) because all of the real compute on those happens inside HACL, which doesn't care.That said, all the
useNative
stuff now quietly convertsLongArray
toCPointer<ULongVar>
. This feels bad somehow, even though it keeps the code as clean as possible.Note: to get this to work at all on my M1 Mac, I had to comment out the
OptimizeForArchitecture.cmake
file. (Related issue: #66). That's probably going to slow things down significantly if we don't find an alternative.