Fork NH template and add clerk signature #5823
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshen0
force-pushed
the
kevin/port-nh-features
branch
from
03319e1 to
29c045a
Compare
kshen0
force-pushed
the
kevin/port-nh-features
branch
from
29c045a to
5f174a8
Compare
kshen0
changed the title
kshen0
commented
Jan 17, 2025
| ).unsafeUnwrap(); | ||
|
|
||
| await expect(result).toMatchPdfSnapshot({ failureThreshold: 0.01 }); | ||
| }); |
There was a problem hiding this comment.
These snapshot tests actually render and add a few seconds to test runtime, increasing runtime from ~45 to ~50 seconds on my machine. Given the not-huge increase in absolute runtime I'm inclined to keep these in and convert to mocking the render after conversion to vitest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
#5795
Note there are still some outstanding things to finish #5795
election.jsonDemo Video or Screenshot
Screen.Recording.2025-01-17.at.10.18.17.AM.mov
Testing Plan
Checklist