Issue #971 - File realm files MUST NOT trigger Elasticsearch service restart

[lucabelluccini]

Issue #971 - File realm files MUST NOT trigger Elasticsearch service restart

This is a naive implementation and another way would be to handle everything in the elasticsearch_role, elasticsearch_user, elasticsearch_role_mapping providers, letting them create the file if it doesn't exist instead of just parsing them.

Pull request acceptance prerequisites:

• Signed the CLA (if not already signed)
• Rebased/up-to-date with base branch
• Tests pass
• Updated CHANGELOG.md with patch notes (if necessary)
• Updated CONTRIBUTORS (if attribution is requested)

[lucabelluccini]

I'll reiterate on this in next days.

[tylerjl]

Thanks for taking a look at this @lucabelluccini, this is indeed something that would be good to fix. If you happen to run into issues as you're coming up with a way to resolve this, please don't hesitate to ping me directly if you want to discuss potential designs to overcome problems that come up. 👍

[lucabelluccini]

Will take a deeper look in few days. Thank you @tylerjl !

[bilsch]

Just curious is there anything I can do to help on this? I'd love to see a fix for this get merged in!

[fatmcgav]

Hi there,

Firstly, thank you for taking the time to contribute, and apologies for the radio silence from Elastic on this PR.

I'm going to be working on this module over the next few weeks, with an ultimate aim of updating the module to support the elasticsearch 7.x and simplifying the module to make it easier to use.

I'll be reviewing all the open issues and PRs over the next few days, and will merge or provide feedback where appropriate.

So please hang in there whilst we give this module some TLC.

Thanks again.

[fatmcgav]

@lucabelluccini Thank you for taking the time to dive into this issue and PR.

I've labelled it as wontfix currently, as part of the updates of this module for Elasticsearch 7 will remove the support for deploying multiple instances of elasticsearch on a single node. Therefore a lot of this code will be rewritten in the near future.

I will however leave this PR open for the time being so that we can ensure it will be considered as part of the rewrite.

[vox-pupuli-tasks]

Dear @lucabelluccini, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

[vox-pupuli-tasks]

Dear @lucabelluccini, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks