Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old option randomization #495

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

quickbeam123
Copy link
Collaborator

@quickbeam123 quickbeam123 commented Oct 26, 2023

Old option randomization code is (mostly) obsolete and replaced by the --sample_strategy, let's remove.

I am not 100% sure about this. Maybe @selig wants to step in?

The new mechanism uses an external file in a domain-specific language. The language has more power for sampling (e.g., samplers for continuous domains). Also pulling the metadata out of the executable has its advantages (and some disadvantages). In any case, an external file means we can have as many samplers as we want (FOF, HOL, SMT, INDUCTION, SAT, ...) whereas the old mechanisms effort to cater for both SAT and UNS was already getting a bit messy.

The new mechanism doesn't (yet) have problem-property-dependent sampling (which the old one did), but that could be added as an extension.

@selig
Copy link
Contributor

selig commented Oct 26, 2023

The old randomisation code is not currently fit for purpose (it has too many gaps). Given the existence of a new shiny thing, it's unlikely it will be made fit for purpose so it makes sense to remove it.

@MichaelRawson MichaelRawson merged commit e588435 into master Oct 27, 2023
1 check passed
@MichaelRawson MichaelRawson deleted the martin-remove-old-option-randomization branch October 27, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants