-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recommended-type-checked #68
Open
segevfiner
wants to merge
1
commit into
vuejs:main
Choose a base branch
from
segevfiner:recommended-type-checked
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
module.exports = { | ||
extends: [ | ||
require.resolve('./index'), | ||
'plugin:@typescript-eslint/recommended-type-checked' | ||
], | ||
|
||
// the ts-eslint recommended ruleset sets the parser so we need to set it back | ||
parser: require.resolve('vue-eslint-parser'), | ||
|
||
parserOptions: { | ||
parser: require('typescript-eslint-parser-for-extra-files') | ||
}, | ||
|
||
rules: { | ||
// this rule, if on, would require explicit return type on the `render` function | ||
'@typescript-eslint/explicit-function-return-type': 'off', | ||
|
||
// The following rules are enabled in an `overrides` field in the | ||
// `@typescript-eslint/recommended` ruleset, only turned on for TypeScript source modules | ||
// <https://github.com/typescript-eslint/typescript-eslint/blob/cb2d44650d27d8b917e8ce19423245b834db29d2/packages/eslint-plugin/src/configs/eslint-recommended.ts#L27-L30> | ||
|
||
// But as ESLint cannot precisely target `<script lang="ts">` blocks and skip normal `<script>`s, | ||
// no TypeScript code in `.vue` files would be checked against these rules. | ||
|
||
// So we now enable them globally. | ||
// That would also check plain JavaScript files, which diverges a little from | ||
// the original intention of the `@typescript-eslint/recommended` rulset. | ||
// But it should be mostly fine. | ||
'no-var': 'error', // ts transpiles let/const to var, so no need for vars any more | ||
'prefer-const': 'error', // ts provides better types with const | ||
'prefer-rest-params': 'error', // ts provides better types with rest args over arguments | ||
'prefer-spread': 'error', // ts transpiles spread to apply, so no need for manual apply | ||
}, | ||
|
||
overrides: [ | ||
{ | ||
files: ['shims-tsx.d.ts'], | ||
rules: { | ||
'@typescript-eslint/no-empty-interface': 'off', | ||
'@typescript-eslint/no-explicit-any': 'off', | ||
'@typescript-eslint/no-unused-vars': 'off' | ||
} | ||
}, | ||
{ | ||
files: ['*.js', '*.cjs'], | ||
rules: { | ||
// in plain CommonJS modules, you can't use `import foo = require('foo')` to pass this rule, so it has to be disabled | ||
'@typescript-eslint/no-var-requires': 'off' | ||
} | ||
} | ||
] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@segevfiner Curiously, what problems were you running into that required this dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rules that use type checking see the linked issues in the PR description.