Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(compile-vapor): wrap the event handler with withModifiers or withKeys #300

Closed
wants to merge 2 commits into from

Conversation

edison1105
Copy link
Member

No description provided.

Copy link

netlify bot commented Dec 1, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit 95bd686
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/674c1434cf54640008ad4294
😎 Deploy Preview https://deploy-preview-300--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 1, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 95bd686
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/674c14345c76090008421692
😎 Deploy Preview https://deploy-preview-300--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 1, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 81 kB 28.4 kB 25.1 kB
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
runtime-vapor.global.prod.js 46.8 kB (-893 B) 17.7 kB (-377 B) 16.2 kB (-333 B)
vue-vapor.global.prod.js 46.7 kB (-897 B) 17.7 kB (-371 B) 16.2 kB (-338 B)
vue.global.prod.js 158 kB 57.8 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.4 kB 18.4 kB 16.8 kB
createApp 55.5 kB 21.4 kB 19.5 kB
createVaporApp 26 kB (-886 B) 9.89 kB (-379 B) 9.12 kB (-348 B)
createSSRApp 59.5 kB 23.1 kB 21 kB
defineCustomElement 60.3 kB 23 kB 20.9 kB
overall 69.3 kB 26.5 kB 24.1 kB

Copy link

pkg-pr-new bot commented Dec 1, 2024

Open in Stackblitzplayground

@vue/compiler-core

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-core@300

@vue/compiler-dom

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-dom@300

@vue/compiler-ssr

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-ssr@300

@vue/compiler-sfc

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-sfc@300

@vue/compiler-vapor

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-vapor@300

@vue/reactivity

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/reactivity@300

@vue/runtime-core

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-core@300

@vue/runtime-dom

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-dom@300

@vue/runtime-shared

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-shared@300

@vue/runtime-vapor

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-vapor@300

@vue/server-renderer

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/server-renderer@300

@vue/shared

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/shared@300

vue

npm i https://pkg.pr.new/vuejs/vue-vapor/vue@300

@vue/compat

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compat@300

@vue/vapor

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/vapor@300

commit: 95bd686

@@ -57,7 +57,7 @@ const importMap = computed(() => {
'vue/vapor': vapor,
},
}
if (useVaporMode.value) vaporImportMap.imports!.vue = vapor
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line will cause vue and vue/vapor to use the same URL, witch will lead some bugs, see Playground

{
  "imports": {
    "vue": "https://vapor-repl.netlify.app/vue-vapor.esm-browser.js",
    "vue/server-renderer": "https://vapor-repl.netlify.app/server-renderer.esm-browser.js",
    "vue/vapor": "https://vapor-repl.netlify.app/vue-vapor.esm-browser.js"
  },
  "scopes": {}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the row is deleted, the getCurrentInstance() return value will be undefined in setup.

@edison1105 edison1105 marked this pull request as ready for review December 1, 2024 14:01
@Doctor-wu Doctor-wu mentioned this pull request Dec 1, 2024
19 tasks
@edison1105 edison1105 closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants