-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(compile-vapor): wrap the event handler with withModifiers
or withKeys
#300
Conversation
✅ Deploy Preview for vapor-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size ReportBundles
Usages
|
Open in Stackblitz • playground @vue/compiler-core
@vue/compiler-dom
@vue/compiler-ssr
@vue/compiler-sfc
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-shared
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
@vue/vapor
commit: |
@@ -57,7 +57,7 @@ const importMap = computed(() => { | |||
'vue/vapor': vapor, | |||
}, | |||
} | |||
if (useVaporMode.value) vaporImportMap.imports!.vue = vapor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line will cause vue
and vue/vapor
to use the same URL, witch will lead some bugs, see Playground
{
"imports": {
"vue": "https://vapor-repl.netlify.app/vue-vapor.esm-browser.js",
"vue/server-renderer": "https://vapor-repl.netlify.app/server-renderer.esm-browser.js",
"vue/vapor": "https://vapor-repl.netlify.app/vue-vapor.esm-browser.js"
},
"scopes": {}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the row is deleted, the getCurrentInstance()
return value will be undefined in setup.
No description provided.