Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop recordPropMetadata + merge renderEffect #301

Merged
merged 47 commits into from
Dec 11, 2024

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Dec 2, 2024

related #297

Playground main branch
Playground with this PR

Compiler changes:

  • Merge multiple renderEffect into one
  • Introduced caching for prop dependencies. When dependencies remain unchanged, runtime helpers will no longer be called.
  • Combine multiple operations with the same dependencies into the same if block.

Runtime changes:

  • Removed the internal prev checks in methods such as setText, setHtml, setAttr, setClass, setDOMProp, and setValue. Since these methods are not invoked when dependencies remain unchanged, the checks are no longer necessary.
  • Added return values to setStyle and setDynamicProp(s) to serve as prev parameters, enabling comparisons between the old and new values within these methods.
  • Removed recordPropMetadata

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit 9f73dbf
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/67554e942c3bd80008409430
😎 Deploy Preview https://deploy-preview-301--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 9f73dbf
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/67554e9485a3940008b761af
😎 Deploy Preview https://deploy-preview-301--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 2, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 81 kB 28.4 kB 25.1 kB
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
runtime-vapor.global.prod.js 47.8 kB (-187 B) 18.1 kB (-53 B) 16.5 kB (-28 B)
vue-vapor.global.prod.js 47.8 kB (-191 B) 18.1 kB (-52 B) 16.5 kB (-28 B)
vue.global.prod.js 158 kB 57.8 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.4 kB 18.4 kB 16.8 kB
createApp 55.5 kB 21.4 kB 19.5 kB
createVaporApp 27.5 kB (-401 B) 10.5 kB (-97 B) 9.67 kB (-93 B)
createSSRApp 59.5 kB 23.1 kB 21 kB
defineCustomElement 60.3 kB 23 kB 20.9 kB
overall 69.3 kB 26.5 kB 24.1 kB

Copy link

pkg-pr-new bot commented Dec 2, 2024

Open in Stackblitzplayground

@vue/compiler-core

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-core@301

@vue/compiler-dom

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-dom@301

@vue/compiler-ssr

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-ssr@301

@vue/compiler-vapor

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-vapor@301

@vue/compiler-sfc

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-sfc@301

@vue/reactivity

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/reactivity@301

@vue/runtime-core

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-core@301

@vue/runtime-dom

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-dom@301

@vue/runtime-shared

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-shared@301

@vue/runtime-vapor

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-vapor@301

@vue/server-renderer

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/server-renderer@301

@vue/shared

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/shared@301

vue

npm i https://pkg.pr.new/vuejs/vue-vapor/vue@301

@vue/compat

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compat@301

@vue/vapor

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/vapor@301

commit: 9f73dbf

@edison1105 edison1105 changed the title refactor: drop recordPropMetadata refactor: drop recordPropMetadata + merge renderEffect Dec 6, 2024
@edison1105 edison1105 marked this pull request as ready for review December 8, 2024 08:27
@yyx990803 yyx990803 merged commit 1bb9a0f into vuejs:main Dec 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants