-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: drop recordPropMetadata + merge renderEffect #301
Merged
yyx990803
merged 47 commits into
vuejs:main
from
edison1105:refactor/drop_recordPropMetadata
Dec 11, 2024
Merged
refactor: drop recordPropMetadata + merge renderEffect #301
yyx990803
merged 47 commits into
vuejs:main
from
edison1105:refactor/drop_recordPropMetadata
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vapor-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size ReportBundles
Usages
|
Open in Stackblitz • playground @vue/compiler-core
@vue/compiler-dom
@vue/compiler-ssr
@vue/compiler-vapor
@vue/compiler-sfc
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-shared
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
@vue/vapor
commit: |
edison1105
changed the title
refactor: drop recordPropMetadata
refactor: drop recordPropMetadata + merge renderEffect
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #297
Playground main branch
Playground with this PR
Compiler changes:
renderEffect
into oneRuntime changes:
setText
,setHtml
,setAttr
,setClass
,setDOMProp
, andsetValue
. Since these methods are not invoked when dependencies remain unchanged, the checks are no longer necessary.setStyle
andsetDynamicProp(s)
to serve as prev parameters, enabling comparisons between the old and new values within these methods.recordPropMetadata