Unexpected behavior note #450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evmiguel
reviewed
Aug 11, 2022
| unexpectedBehavior, | ||
| unexpectedBehaviorNote | ||
| ) => { | ||
| if (!unexpectedBehaviorNote && unexpectedBehavior.id === 'OTHER') { |
There was a problem hiding this comment.
Non-blocking: Are we still expecting a behavior note to be filled when OTHER? I thought the note would be decoupled from all undesirable behaviors.
evmiguel
reviewed
Aug 11, 2022
| ...UNEXPECTED_BEHAVIORS.map(description => ({description, requireExplanation: false})), | ||
| {description: "Other", requireExplanation: true}, | ||
| ...UNEXPECTED_BEHAVIORS.map(description => ({ description, requireExplanation: false })), | ||
| { description: 'Other', requireExplanation: true }, |
There was a problem hiding this comment.
Same question here. Is Other supposed to be coupled to the explanation?
evmiguel
reviewed
Aug 11, 2022
| ) | ||
| ), | ||
| fragment( | ||
| // TODO: Figure out why this isn't appearing |
There was a problem hiding this comment.
Looks like this is appearing!
evmiguel
requested changes
Aug 11, 2022
evmiguel
reviewed
Aug 11, 2022
| resultUnexpectedBehavior.behaviors.some( | ||
| ({ checked, requireExplanation }) => requireExplanation && checked | ||
| ), | ||
| description: resultUnexpectedBehavior.behaviors.some( |
There was a problem hiding this comment.
I'm not seeing this. How do I get to this state?
|
Superseded by #596 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the unexpected behavior note available for all unexpected behaviors instead of just "Other."
Goes along with a PR in the ARIA-AT repo which is here: w3c/aria-at#802 The two PRs can be merged in any order and at different times if needed. But following review changes to one might require changes to the other.